remove runtime system deprecations#28380
Merged
JeffBezanson merged 1 commit intomasterfrom Aug 4, 2018
Merged
Conversation
mbauman
reviewed
Jul 31, 2018
| @test_throws BoundsError((1, 2), 3) begin; a, b, c = 1, 2; end | ||
| let a = [] | ||
| @test_broken try; a[]; catch ex; (ex::BoundsError).a === a && ex.i == (1,); end # TODO: Re-enable after PLI | ||
| @test try; a[]; catch ex; (ex::BoundsError).a === a && ex.i == (); end |
Member
There was a problem hiding this comment.
Yes! This is correct. I don't doubt that we used to throw a BoundsError that had a implicitly generated linear 1, but this is better.
b5fe200 to
a65d0f5
Compare
Member
|
Needs a rebase. |
a65d0f5 to
bbf64b6
Compare
alyst
pushed a commit
to alyst/julia
that referenced
this pull request
Aug 9, 2018
KristofferC
pushed a commit
that referenced
this pull request
Feb 11, 2019
vtjnash
added a commit
that referenced
this pull request
Jul 9, 2020
These functions were changed in #28380, but their tfuncs were not changed at that time also.
vtjnash
added a commit
that referenced
this pull request
Jul 9, 2020
These functions were changed in #28380, but their tfuncs were not changed at that time also.
vtjnash
added a commit
that referenced
this pull request
Jul 10, 2020
These functions were changed in #28380, but their tfuncs were not changed at that time also.
simeonschaub
pushed a commit
to simeonschaub/julia
that referenced
this pull request
Aug 11, 2020
These functions were changed in JuliaLang#28380, but their tfuncs were not changed at that time also.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mbauman There's a test in test/core.jl that expects a BoundsError with indices
(1,)froma[]. I found it was()instead. Is this right?