make simd loop over ranges perform better#28166
Merged
KristofferC merged 1 commit intomasterfrom Jul 18, 2018
Merged
Conversation
07995a7 to
06e7ad4
Compare
Member
Author
|
@nanosoldier |
mbauman
approved these changes
Jul 18, 2018
Collaborator
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan |
Member
Author
|
Some bonus SIMD stuff improvements in there too. Unexpected, but I'll take it. |
LilithHafner
added a commit
to LilithHafner/julia
that referenced
this pull request
May 8, 2022
KristofferC
pushed a commit
that referenced
this pull request
May 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #27773 (and likely the
sumlinear_viewbenchmarks in #27030)Apparently
firstindex(::UnitRange)is right now too complex to see through. Arguably it would be better to try to figure out why it cannot be folded but it is a quite deep chain of calls...Regression introduced in #27038 (with no Nanosoldier run, perhaps it was nonfunctional at the time)