Revert "make simd loop over ranges perform better (#28166)"#45230
Merged
KristofferC merged 1 commit intoJuliaLang:masterfrom May 10, 2022
Merged
Revert "make simd loop over ranges perform better (#28166)"#45230KristofferC merged 1 commit intoJuliaLang:masterfrom
KristofferC merged 1 commit intoJuliaLang:masterfrom
Conversation
Member
|
Reverting should be OK as a temporary fix, as the original concern has gone. julia> _firstindex(x) = Base.@invoke firstindex(x::AbstractArray)
f (generic function with 1 method)
julia> @code_typed _firstindex(1:2:10)
CodeInfo(
1 ─ invoke Base.length(x::StepRange{Int64, Int64})::Int64 # we failed to omit this call
└── return 1
) => Int64
julia> @code_warntype length(StepRange(1,Int128(1),1))
MethodInstance for length(::StepRange{Int64, Int128})
from length(r::OrdinalRange{T}) where T<:Union{Int128, Int64, UInt128, UInt64} in Base at range.jl:713
Static Parameters
T = Int64
Arguments
#self#::Core.Const(length)
r::StepRange{Int64, Int128}
Locals
a::Union{Int128, Int64}
diff::Int64
s::Int128
@_6::Bool
Body::Union{Int128, Int64} # not stable |
Member
|
@nanosoldier |
Collaborator
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. |
Member
Author
|
This is my first time reviewing nanosoldier results, but all the regressions look like noise to me with the possible exception of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think someone somewhere has fixed this upstream since 2018. To whom it may concern, thanks!
Fixes #45223