restore MSVC compatibility#10528
Merged
JeffBezanson merged 4 commits intomasterfrom Mar 19, 2015
Merged
Conversation
declare vasprintf before using use JL_GC_PUSH1 instead of JL_GC_PUSH, latter requires C99 vararg macros use __alignof instead of __alignof__ for msvc remove define for _isnan, no longer seems to be necessary disable ASM_COPY_STACKS for MSVC Don't include valgrind.h for MSVC use _write instead of write
skip include of strings.h don't do 0-size array workaround on msvc 8G array is too large for msvc rearrange #ifdef MEMDEBUG to be outside of MARK macro expansion use NOINLINE define instead of __attribute((noinline)) explicit cast on VirtualAlloc output _BitScanForward takes a pointer to unsigned long, not int
Member
There was a problem hiding this comment.
travis didn't complain, but should this have an #ifdef MSVC?
Contributor
Author
There was a problem hiding this comment.
Don't think so, we have our own at src/support/asprintf.c that we use elsewhere, just not declared in this file yet.
JeffBezanson
added a commit
that referenced
this pull request
Mar 19, 2015
restore MSVC compatibility
JeffBezanson
added a commit
that referenced
this pull request
Mar 20, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Speaks for itself I think. I probably need to rebuild the MSVC LLVM binaries that I had previously uploaded, since my hacky replacement for llvm-config doesn't seem to work any more.