Remove deprecations (and coming deprecations)#190
Merged
ararslan merged 2 commits intoJuliaCI:masterfrom Feb 27, 2018
Merged
Conversation
When a deprecation appears in the hot loop of a tuned benchmark, BaseBenchmarks basically becomes non-terminating. So this PR anticipates some of the coming changes in JuliaLang/julia#24368. I have also taken the opportunity to fix the few other deprecations I ran into -- none of those were in hot loops. Note that I have significantly changed some of these algorithms in order to better take advantage of dot-fusion. I think that is in the spirit of those specific benchmarks, but if desired I can happily revert that back to the most-minimal change required to avoid the deprecation.
ararslan
reviewed
Feb 21, 2018
src/array/ArrayBenchmarks.jl
Outdated
| S3d = view(A3d, 1:10, 1:10, 1:10) | ||
| arrays = (makearrays(Int32, σ, σ)..., makearrays(Float32, σ, σ)..., trues(σ, σ), A3d, S3d) | ||
| ranges = (1:10^5, 10^5:-1:1, 1.0:1e5, linspace(1,2,10^4)) | ||
| ranges = (1:10^5, 10^5:-1:1, 1.0:1e5, range(1,stop=2,length=10^4)) |
Member
There was a problem hiding this comment.
Is there Compat for this on 0.6? I think we need to keep supporting 0.6 here (unfortunate as that is) until we're certain there won't be another 0.6 release.
Member
Author
There was a problem hiding this comment.
Ah, right, I forgot about that. I didn't check for Compat-ability. CI will tell us, I'm sure.
Member
Author
|
Bump! Would it be possible to merge this and get it up on Nanosoldier? I'd like to run JuliaLang/julia#24368 through perf tests. |
Member
|
Thanks Matt! (Both for the contribution and the reminder 😉) I'll retune the benchmarks and run Nanosoldier on your PR once that's ready. |
mbauman
added a commit
to mbauman/BaseBenchmarks.jl
that referenced
this pull request
Apr 4, 2018
This reverts commit 83374c1.
mbauman
added a commit
to mbauman/BaseBenchmarks.jl
that referenced
this pull request
Apr 4, 2018
…ons) (JuliaCI#190)"" This partially reverts commit 3d0426e, restoring the non-broadcasting related changes.
ararslan
pushed a commit
that referenced
this pull request
Apr 25, 2018
…n setindex! (#195) * Revert "Remove deprecations (and coming deprecations) (#190)" This reverts commit 83374c1. * (Partially) Revert "Revert "Remove deprecations (and coming deprecations) (#190)"" This partially reverts commit 3d0426e, restoring the non-broadcasting related changes. * Anticipate deprecating implicit scalar broadcasting in setindex!
Keno
pushed a commit
that referenced
this pull request
Feb 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a deprecation appears in the hot loop of a tuned benchmark, BaseBenchmarks basically becomes non-terminating. So this PR anticipates some of the coming changes in JuliaLang/julia#24368. I have also taken the opportunity to fix the few other deprecations I ran into -- none of those were in hot loops.
Note that I have significantly changed some of these algorithms in order to better take advantage of dot-fusion. I think that is in the spirit of those specific benchmarks, but if desired I can happily revert that back to the most-minimal change required to avoid the deprecation.