Revert "Remove deprecations (and coming deprecations) (#190)"

mbauman · mbauman · commit 3d0426ed7f16 · 2018-04-04T16:12:30.000-04:00
This reverts commit 83374c1.
diff --git a/src/array/ArrayBenchmarks.jl b/src/array/ArrayBenchmarks.jl
@@ -243,8 +243,8 @@ function perf_true_load!(result)
     return result
 end
 
-n, vals = 10^6, -3:3
-a, b = samerand(vals, n), samerand(vals)
+n, range = 10^6, -3:3
+a, b = samerand(range, n), samerand(range)
 
 boolarr = Vector{Bool}(undef, n)
 if VERSION >= v"0.7.0-DEV.2687"
diff --git a/src/array/subarray.jl b/src/array/subarray.jl
@@ -13,13 +13,13 @@ function perf_lucompletepivCopy!(A)
         μ, λ = _maxind(As)
         μ += k-1; λ += k-1
         rowpiv[k] = μ
-        A[[k,μ], 1:n] .= A[[μ,k], 1:n]
+        A[[k,μ], 1:n] = A[[μ,k], 1:n]
         colpiv[k] = λ
-        A[1:n, [k,λ]] .= A[1:n, [λ,k]]
+        A[1:n, [k,λ]] = A[1:n, [λ,k]]
         if A[k,k] ≠ 0
             ρ = k+1:n
-            A[ρ, k] ./= A[k, k]
-            A[ρ, ρ] .-= A[ρ, k:k] .* A[k:k, ρ]
+            A[ρ, k] = A[ρ, k]/A[k, k]
+            A[ρ, ρ] = A[ρ, ρ] - A[ρ, k:k] * A[k:k, ρ]
         end
     end
     return (A, rowpiv, colpiv)
@@ -34,13 +34,13 @@ function perf_lucompletepivSub!(A)
         μ, λ = _maxind(As)
         μ += k-1; λ += k-1
         rowpiv[k] = μ
-        A[[k,μ], 1:n] .= view(A, [μ,k], 1:n)
+        A[[k,μ], 1:n] = view(A, [μ,k], 1:n)
         colpiv[k] = λ
-        A[1:n, [k,λ]] .= view(A, 1:n, [λ,k])
+        A[1:n, [k,λ]] = view(A, 1:n, [λ,k])
         if A[k,k] ≠ 0
             ρ = k+1:n
-            A[ρ, k] ./= A[k, k]
-            A[ρ, ρ] .-= view(A, ρ, k:k) .* view(A, k:k, ρ)
+            A[ρ, k] = view(A, ρ, k)/A[k, k]
+            A[ρ, ρ] = view(A, ρ, ρ) - view(A, ρ, k:k) * view(A, k:k, ρ)
         end
     end
     return (A, rowpiv, colpiv)
diff --git a/src/array/sumindex.jl b/src/array/sumindex.jl
@@ -287,7 +287,7 @@ end
 function makearrays(::Type{T}, r::Integer, c::Integer) where T
     A = samerand(T, r, c)
     B = similar(A, r+1, c+1)
-    B[1:r, 1:c] .= A
+    B[1:r, 1:c] = A
     AS = ArrayLS(B)
     ASS = ArrayLSLS(B)
     AF = ArrayLF(A)
diff --git a/src/problem/GoGame.jl b/src/problem/GoGame.jl
@@ -351,15 +351,15 @@ function generate_move(board::Board, color::Int)
             # Further require the move not to be suicide for the opponent...
             if !suicide(board, ai, aj, other_color(color))
                 num_moves += 1
-                moves[:,num_moves] .= (ai, aj)
+                moves[:,num_moves] = [ai, aj]
             else
                 # ...however, if the move captures at least one stone,
                 # consider it anyway.
                 for k = 1:4
                     (bi, bj) = neighbor(ai, aj, k)
                     if on_board(board, bi, bj) && board[bi, bj] == other_color(color)
                         num_moves += 1
-                        moves[:,num_moves] .= (ai, aj)
+                        moves[:,num_moves] = [ai, aj]
                         break
                     end
                 end
diff --git a/src/problem/Laplacian.jl b/src/problem/Laplacian.jl
@@ -33,7 +33,7 @@ function ddx_spdiags(m)
     # Append new d[k]-th diagonal to compact form
     for k = 1:p
         i = max(1,1-d[k]):min(m,n-d[k])
-        a[(len[k]+1):len[k+1],:] .= [i i.+d[k] B[i.+(m>=n)*d[k],k]]
+        a[(len[k]+1):len[k+1],:] = [i i.+d[k] B[i.+(m>=n)*d[k],k]]
     end
 
     return sparse(a[:,1], a[:,2], a[:,3], m, n)
