Skip to content

Update hydra dependencies to 5.0.0-alpha.4#4731

Merged
mnaamani merged 2 commits intoJoystream:masterfrom
Lezek123:ephesus-update-hydra
Apr 24, 2023
Merged

Update hydra dependencies to 5.0.0-alpha.4#4731
mnaamani merged 2 commits intoJoystream:masterfrom
Lezek123:ephesus-update-hydra

Conversation

@Lezek123
Copy link
Copy Markdown
Contributor

@Lezek123 Lezek123 commented Apr 6, 2023

Update dependencies to include the latest hydra fix: Joystream/hydra#521

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 6, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
pioneer-testnet ⬜️ Ignored (Inspect) Apr 20, 2023 9:21am

zeeshanakram3
zeeshanakram3 approved these changes Apr 6, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@zeeshanakram3 zeeshanakram3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Lezek123 Lezek123 marked this pull request as draft April 6, 2023 18:11
@Lezek123
Copy link
Copy Markdown
Contributor Author

Lezek123 commented Apr 6, 2023

There seems to be some processing issue as https://github.com/Joystream/joystream/actions/runs/4627444652/jobs/8189300037?pr=4731 repeatedly fails.
To be further investigated, marking PR as draft for now.

@Lezek123
Copy link
Copy Markdown
Contributor Author

Lezek123 commented Apr 7, 2023 •
edited
Loading

I think the issue is that storageSync test produces a large amount of events in a single block, while currently we have a limit of the hydra processor event queue size set to 400 events.

Because of the way I implemented the fix in Hydra, in case the number of events in a block exceeds 400, the processor will be stuck waiting for all the events in a given block to be fetched from the indexer, which will never happen, because no new events will be fetched once the queue is full.

I will need to adjust my fix to take this into account.

@Lezek123 Lezek123 mentioned this pull request Apr 7, 2023
Merged
@Lezek123 Lezek123 marked this pull request as ready for review April 21, 2023 08:37
@Lezek123 Lezek123 changed the title Update hydra dependencies to 5.0.0-alpha.3 Update hydra dependencies to 5.0.0-alpha.4 Apr 21, 2023
@mnaamani
Copy link
Copy Markdown
Member

mnaamani commented Apr 24, 2023

Looks good.
I will address the failing runtime_upgrade integration test in #4744

@mnaamani mnaamani changed the base branch from ephesus to master April 24, 2023 17:59
mnaamani
mnaamani approved these changes Apr 24, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@mnaamani mnaamani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, deployed to production (backup cluster) synced without issues.
I changed base branch to master.

@mnaamani mnaamani merged commit 37f6666 into Joystream:master Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mnaamani mnaamani mnaamani approved these changes

@zeeshanakram3 zeeshanakram3 zeeshanakram3 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Lezek123 @mnaamani @zeeshanakram3