Processor syncing fix (blocksWithEvents)#521
Merged
zeeshanakram3 merged 2 commits intoJoystream:masterfrom Apr 6, 2023
Merged
Conversation
added 2 commits
April 3, 2023 21:42
affects: @joystream/hydra-cli, @joystream/hydra-processor \`blocksWithEvents\` \`AsyncGenerator\` was not properly awaiting the promise returned by \`pWaitFor\`. This promise was supposed to stop the generator from yeilding next block until all evens emitted in that block were fetched from the indexer. Becasue it was not properly awaited, it was possible for the \`blocksWithEvents\` to yeild a block with an incomplete array of events in case the indexer was responsing to requests more slowly than usual. As a result, the processor would think it processed a full block and update the \`last_scanned_block\` value in the database, while not actually processing all events in that block. This is the scenario that has caused issues such as Joystream#519 ISSUES CLOSED: Joystream#519
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #519
blocksWithEventsAsyncGeneratorwas not properly awaiting the promise returned bypWaitFor. This promise was supposed to stop the generator from yeilding next block until all evens emitted in that block were fetched from the indexer.Becasue it was not properly awaited, it was possible for the
blocksWithEventsto yeild a block with an incomplete array of events in case the indexer was responsing to requests more slowly than usual.As a result, the processor would think it processed a full block and update the
last_scanned_blockvalue in the database, while not actually processing all events from that block. This is the scenario that has caused issues such as #519