Improve docker image publish and runtime upgrade test workflow#4744
Merged
mnaamani merged 12 commits intoJoystream:masterfrom May 3, 2023
Merged
Improve docker image publish and runtime upgrade test workflow#4744mnaamani merged 12 commits intoJoystream:masterfrom
mnaamani merged 12 commits intoJoystream:masterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
bdb0b86 to
90cbc19
Compare
8a3fef7 to
a317f72
Compare
Merged
dobertRowneySr
approved these changes
May 3, 2023
Collaborator
dobertRowneySr
left a comment
There was a problem hiding this comment.
LGTM, I have just left a small question
| env: | ||
| RUNTIME: mainnetDev | ||
| TARGET_RUNTIME: latest | ||
| TARGET_RUNTIME: ${{ needs.build_images.outputs.runtime }} |
Collaborator
There was a problem hiding this comment.
Good job, this clearly needed to be adjusted
| uses: actions/cache@v3 | ||
| env: | ||
| cache-name: joystream-node-docker | ||
| cache-name: joystream-node-docker-1 |
Collaborator
There was a problem hiding this comment.
why there's a need for the -1 prefix?
Member
Author
There was a problem hiding this comment.
Here I just wanted to force github to use a new cache and not rely on previously cached artifacts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
joystream/node:latestfrom master branch is skipped injoystream-node-docker.ymlworkflow. eg. https://github.com/Joystream/joystream/actions/runs/4675415174/jobs/8280515894 So factored out the step into its own workflowjoystream-node-docker-publish.yml.