Argus/Colossus and CLI create/update video tests#4407
Merged
mnaamani merged 13 commits intoJoystream:carthagefrom Nov 8, 2022
Merged
Argus/Colossus and CLI create/update video tests#4407mnaamani merged 13 commits intoJoystream:carthagefrom
mnaamani merged 13 commits intoJoystream:carthagefrom
Conversation
added 7 commits
October 26, 2022 11:01
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Contributor
zeeshanakram3
left a comment
There was a problem hiding this comment.
- Running
yarn generate:allin packagescli,storage-node,distributor-node&tests/network-testsupdates some of the auto-generated GraphQL schema/queries files. Can you please check that these files are up-to-date - Integration tests are failing In the PR, however I ran the tests locally and they are passing for me. So seems like rerunning the CI checks would fix it.
- While running integration tests, we get the following deprecation warning, I guess it shouldn't be a problem?
(node:173001) [DEP0128] DeprecationWarning: Invalid 'main' field in '/workspace/joystream/node_modules/@joystream/distributor-node-client/package.json' of 'lib/index.js'. Please either fix that or report it to the module author
| } from '@joystream/cli/src/Types' | ||
|
|
||
| export default async function createAndUpdateChannel({ api, query, env }: FlowProps): Promise<void> { | ||
| const debug = extendDebug('flow:createChannel') |
Contributor
There was a problem hiding this comment.
Shouldn't this also be renamed to:
Suggested change
| const debug = extendDebug('flow:createChannel') | |
| const debug = extendDebug('flow:channelAndVideos') |
mnaamani
approved these changes
Nov 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
┆Issue is synchronized with this Asana task by Unito