-
Notifications
You must be signed in to change notification settings - Fork 117
Integration tests: More test coverage for Argus & Colossus #4404
Copy link
Copy link
Closed
Labels
argusArgus distributor nodeArgus distributor nodecolossusnetwork-integration-testEnd-to-end full network integration testEnd-to-end full network integration test
Description
Based on #4290, I investigated the current state of Colossus / Argus integration tests.
Currently, although we have some tests for Argus and Colossus CLIs, the tests of the actual APIs are practically non-existent, more specifically:
- We have
createAndUpdateChannelflow, but it passes regardless of whether the actual uploads were successful, because CLI only logs warnings in this case - We don't try to fetch the uploaded assets from the distributor node and don't test any other Colossus/Argus api endpoints
For minimum test coverage I suggest following changes:
- CLI should use non-zero exit code in case there are any failed uploads
- We should add tests for creating/updating a video through CLI (we only have such tests for channel now)
- We should always try to fetch (from Argus) & verify all uploaded data in the CLI integration tests
┆Issue is synchronized with this Asana task by Unito
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
argusArgus distributor nodeArgus distributor nodecolossusnetwork-integration-testEnd-to-end full network integration testEnd-to-end full network integration test