YPP Landing Page review fixes#3335
Merged
drillprop merged 3 commits intoJoystream:yppfrom Oct 14, 2022
Merged
Conversation
toiletgranny
suggested changes
Oct 12, 2022
Contributor
toiletgranny
left a comment
There was a problem hiding this comment.
WOW, just WOW! I can't believe how much more alive the page feels now, this is so great! And Lighthouse's improved performance, SEO, and accessibility scores speak for themselves! ❤️
I can see that this little image in the background is still problematic, though. Even Lighthouse complains about its large size (<800 KB) and the lack of width and height attributes. I thought that perhaps I could help with the first one, by providing you with an exported and compressed image that's still @2x scale, under 300 KB, and has no compression issues. Please, see if the below image will work. It's a JPEG, as GitHub won't let me upload WebP, but I'm sure you can convert the image to WebP yourself (without compressing it).
Contributor
|
@toiletgranny I'm not sure if this will work actually. This particular image was semi-transparent(I think that's why it so heavy). If we use your image, the background will be different if I'm not mistaken Edit: This is how it will look like: |
drillprop
suggested changes
Oct 12, 2022
packages/atlas/src/views/global/YppLandingView/YppCardsSection.styles.ts
Show resolved
Hide resolved
packages/atlas/src/views/global/YppLandingView/YppThreeStepsSection.styles.ts
Show resolved
Hide resolved
packages/atlas/src/views/global/YppLandingView/YppThreeStepsSection.styles.ts
Outdated
Show resolved
Hide resolved
Contributor
|
@drillprop Ah, of course, you're right. Here's the same image with the correct background color! |
drillprop
approved these changes
Oct 14, 2022
toiletgranny
approved these changes
Oct 14, 2022
drillprop
pushed a commit
that referenced
this pull request
Oct 24, 2022
* YPP Landing Page review fixes * PR FIX * add missing width and height
drillprop
pushed a commit
that referenced
this pull request
Nov 9, 2022
* YPP Landing Page review fixes * PR FIX * add missing width and height
drillprop
pushed a commit
that referenced
this pull request
Nov 9, 2022
* YPP Landing Page review fixes * PR FIX * add missing width and height
drillprop
pushed a commit
that referenced
this pull request
Nov 9, 2022
* YPP Landing Page review fixes * PR FIX * add missing width and height
drillprop
pushed a commit
that referenced
this pull request
Dec 28, 2022
* YPP Landing Page review fixes * PR FIX * add missing width and height
attemka
added a commit
that referenced
this pull request
Feb 9, 2023
* YPP Side nav icon (#3210) * Google authentication flow (#3214) * YPP landing page - hero section (#3217) * Benefit card (#3229) * Ypp landing page (#3230) * YPP Dashboard (#3250) * Add YPP missing headtags (#3260) * Reward section (#3242) * UI for YPP authorization flow (#3243) * YPP referrer support (#3259) * Integrate YPP authorization with Google (#3270) * Remove unnecessary benefit card illustrations (#3310) * YPP Landing Page review fixes (#3335) * make ypp experience optional (#3364) * Ypp integration (#3437) * update api url and client id (#3453) * update api url (#3456) * add redirect url to post req, update url (#3461) * Ypp studio views (#3452) * Fix google auth scope (#3475) * add oauth scope for user info (#3478) * Fix issue YPP landing page RWD issue (#3484) * Move tiers definition to config, make tiers customizable (#3473) * 🐌 Small YPP auth modal improvements (#3487) * Recent creators carousel (#3481) * set access_type to offline in oauth authorization request (#3503) * Assign onClick to rest action buttons (#3506) * Change default env to next (#3507) * Make YPP rewards customizable (#3488) * Add select category input in ypp flow (#3514) * 🔦 Flashing ypp routes (#3513) * Fetch requirements from backend (#3474) * 💧 Dropdown in popper (#3515) * fix issue with not setting videocategory id (#3530) * Payments welcome modal (#3432) * Payments table component (#3438) * Channel payouts POC (#3359) * Overview widgets (#3451) * 🤑 My payments ➡️ Transactions (#3471) * 🎐 Quick fix on claim reward tx (#3502) * Fix issue with not being able run app locally (#3541) * Make sure ypp check doesn't fire on studio while there isn't any channel (#3528) * 🌞 Suggestions on YPP modal details (#3512) * create video tile variation for synced video (#3520) * fix payments Buffer build issues (#3559) * 🥇 Make ypp widget customable (#3521) * Required change (#3563) * Transfer invalid snackbar to onclick (#3551) * Change error flow on auth cancelation (#3553) * Change limit of the video title (#3564) * 🍸 YPP cosmetics (#3546) * Scroll to top on ypp auth modal step change (#3554) * 💺 YPP success modal copy (#3549) * Tier boundary (#3572) * Fix ypp referral (#3548) *⚠️ Suspended YPP info (#3550) * 🤙 Add YPP sync banner (#3575) * 🥼 Payments layout update (#3577) * 📥 Quota reached information (#3579) * 🦭 Ypp settings tab (#3571) * ♏ Add email scope for Google OAuth (#3576) * 📃 Payments claim errors (#3578) * 🚘 YPP auth - sync step (#3565) *⚠️ Suspended YPP info (#3550) * Fix issue with showing undefined in ypp requirements step (#3588) * ㊙️ YPP sync check (#3585) * Ypp syncing integration (#3602) * changed config to include additional widgets in YTT(#3610) * tuned ypp rewards, changed texts, minor bugfixes (#3570) * changed discord URL (#3610) * buttons text changed to shortened variant (#3570) * Update ypp backend statuses (#3671) * YT banner is now visible only on "all videos tab"(#3648) * TnC minor changes (#3442) * moved ypp TnC to feature level (#3442) * fixed texts, signed-in button state (#3570) * new discord widget link (#3570) * Fixed YPP status var naming (#3689) * 🍶 Filter out YT private videos and turn on polling only for uploading videos (#3655) * 😩 Withdraw action on payments (#3691) * removed userinfo.profile from scope (#3692) * ℹ️ Banner on ypp sync step (#3668) * Added payments table data refetch (#3693) * added refetching for payments table (#3682) * moved data refetching to onTxSync (#3682) * 🧑💻 Introduce react-query in all places (#3614) *‼️ Banner for YPP payout info (#3690) * Fixed suspended view in YppDashboard (#3713) * fix Discord suspendedSupportLink (#3717) * Update google console id for ypp (#3724) * removed payouts dashboard for YPP (#3706) * Fix issue with breaking the app (#3728) * 🏴 Payments widgets changes (#3718) * changed copy for YPP modal (#3722) * removed payouts dashboard for YPP (#3716) * removed payouts dashboard for YPP (#3706) * removed payout types, added payments screen (#3706) * returned payments navigation, changed default env to dev (#3706) --------- Co-authored-by: Rafał Pawłow <pawlow.rafal@gmail.com> Co-authored-by: Bartosz Dryl <drylbartosz@gmail.com> Co-authored-by: Klaudiusz Dembler <accounts@kdembler.com> Co-authored-by: Zeeshan Akram <37098720+zeeshanakram3@users.noreply.github.com> Co-authored-by: WRadoslaw <92513933+WRadoslaw@users.noreply.github.com> Co-authored-by: WRadoslaw <r.wyszynski00@gmail.com> Co-authored-by: Artem <Artem Slugin>
attemka
added a commit
that referenced
this pull request
Mar 10, 2023
* 👨🚀 Failed asset upload actions (#3592) * Required changes * Small fix and linter * Fix action when only thumbnail failed * Fix balance tooltip issues (#3605) * fix balance tooltip issues * add entry to changelog * Fix missaligned text in search box (#3611) * 🌫️ Feature/content focus (#3606) * AppKV * Add content focus to config * Add welcome modal * Rework on SignIn modal * StudioWelcomeView.tsx rework * Replace png with webp * Add fade to KV * Fix KV styling on modals * CR fixes * Small change * Video hero placeholder (#3608) * create video hero placeholder * create placeholder for video category hero * add background images * use background image instead of img * add entry to changelog * add app tagline, cr fixes * fix issues when video is present * 🍼 Add video background (#3629) * Included platform royalty in NFT selling details (#3640) * Included platform royalty in NFT selling details * added feature to changelog (#3640) Co-authored-by: Artem <Artem Slugin> * fixed tooltips multiline (#3623) * included Joystream license(#3609) * prettier ignores yml (#3609) * 🦭 Pick closest storage operator (#3637) * Fetch coords for storage operators * Map storage operators and return closest one to the user * Utilize new functions * 🧇 Retry wallet connection (#3643) * Retry wallet connection * Apply timeout only for automatical wallet signin * Merge changes from master into dev (#3696) * Release 1.2.2 * Release 1.2.3 (#3620) --------- Co-authored-by: WRadoslaw <92513933+WRadoslaw@users.noreply.github.com> * add section on creating new QN video categories to operator guide (#3707) * add section on creating new QN video categories to operator guide Co-authored-by: Bartosz Dryl <drylbartosz@gmail.com> --------- Co-authored-by: Bartosz Dryl <drylbartosz@gmail.com> * add head tags to NotificationsView and MemberView (#3710) * added snackbar for insufficient balance bid/buy(#3715) Co-authored-by: Artem <Artem Slugin> * ❎ Negative balance (#3646) * CR fixes * Correct debt check * Fix: consider only invitation lock * Remove log * Reformat components * Hopefully last adaptation * fix issue with too big number (#3727) * resolving merge conflicts (#3741) * Set default timeout to snackbar (#3744) * set default timeout to snackbar * YPP-v1 (#3751) * YPP Side nav icon (#3210) * Google authentication flow (#3214) * YPP landing page - hero section (#3217) * Benefit card (#3229) * Ypp landing page (#3230) * YPP Dashboard (#3250) * Add YPP missing headtags (#3260) * Reward section (#3242) * UI for YPP authorization flow (#3243) * YPP referrer support (#3259) * Integrate YPP authorization with Google (#3270) * Remove unnecessary benefit card illustrations (#3310) * YPP Landing Page review fixes (#3335) * make ypp experience optional (#3364) * Ypp integration (#3437) * update api url and client id (#3453) * update api url (#3456) * add redirect url to post req, update url (#3461) * Ypp studio views (#3452) * Fix google auth scope (#3475) * add oauth scope for user info (#3478) * Fix issue YPP landing page RWD issue (#3484) * Move tiers definition to config, make tiers customizable (#3473) * 🐌 Small YPP auth modal improvements (#3487) * Recent creators carousel (#3481) * set access_type to offline in oauth authorization request (#3503) * Assign onClick to rest action buttons (#3506) * Change default env to next (#3507) * Make YPP rewards customizable (#3488) * Add select category input in ypp flow (#3514) * 🔦 Flashing ypp routes (#3513) * Fetch requirements from backend (#3474) * 💧 Dropdown in popper (#3515) * fix issue with not setting videocategory id (#3530) * Payments welcome modal (#3432) * Payments table component (#3438) * Channel payouts POC (#3359) * Overview widgets (#3451) * 🤑 My payments ➡️ Transactions (#3471) * 🎐 Quick fix on claim reward tx (#3502) * Fix issue with not being able run app locally (#3541) * Make sure ypp check doesn't fire on studio while there isn't any channel (#3528) * 🌞 Suggestions on YPP modal details (#3512) * create video tile variation for synced video (#3520) * fix payments Buffer build issues (#3559) * 🥇 Make ypp widget customable (#3521) * Required change (#3563) * Transfer invalid snackbar to onclick (#3551) * Change error flow on auth cancelation (#3553) * Change limit of the video title (#3564) * 🍸 YPP cosmetics (#3546) * Scroll to top on ypp auth modal step change (#3554) * 💺 YPP success modal copy (#3549) * Tier boundary (#3572) * Fix ypp referral (#3548) *⚠️ Suspended YPP info (#3550) * 🤙 Add YPP sync banner (#3575) * 🥼 Payments layout update (#3577) * 📥 Quota reached information (#3579) * 🦭 Ypp settings tab (#3571) * ♏ Add email scope for Google OAuth (#3576) * 📃 Payments claim errors (#3578) * 🚘 YPP auth - sync step (#3565) *⚠️ Suspended YPP info (#3550) * Fix issue with showing undefined in ypp requirements step (#3588) * ㊙️ YPP sync check (#3585) * Ypp syncing integration (#3602) * changed config to include additional widgets in YTT(#3610) * tuned ypp rewards, changed texts, minor bugfixes (#3570) * changed discord URL (#3610) * buttons text changed to shortened variant (#3570) * Update ypp backend statuses (#3671) * YT banner is now visible only on "all videos tab"(#3648) * TnC minor changes (#3442) * moved ypp TnC to feature level (#3442) * fixed texts, signed-in button state (#3570) * new discord widget link (#3570) * Fixed YPP status var naming (#3689) * 🍶 Filter out YT private videos and turn on polling only for uploading videos (#3655) * 😩 Withdraw action on payments (#3691) * removed userinfo.profile from scope (#3692) * ℹ️ Banner on ypp sync step (#3668) * Added payments table data refetch (#3693) * added refetching for payments table (#3682) * moved data refetching to onTxSync (#3682) * 🧑💻 Introduce react-query in all places (#3614) *‼️ Banner for YPP payout info (#3690) * Fixed suspended view in YppDashboard (#3713) * fix Discord suspendedSupportLink (#3717) * Update google console id for ypp (#3724) * removed payouts dashboard for YPP (#3706) * Fix issue with breaking the app (#3728) * 🏴 Payments widgets changes (#3718) * changed copy for YPP modal (#3722) * removed payouts dashboard for YPP (#3716) * removed payouts dashboard for YPP (#3706) * removed payout types, added payments screen (#3706) * returned payments navigation, changed default env to dev (#3706) --------- Co-authored-by: Rafał Pawłow <pawlow.rafal@gmail.com> Co-authored-by: Bartosz Dryl <drylbartosz@gmail.com> Co-authored-by: Klaudiusz Dembler <accounts@kdembler.com> Co-authored-by: Zeeshan Akram <37098720+zeeshanakram3@users.noreply.github.com> Co-authored-by: WRadoslaw <92513933+WRadoslaw@users.noreply.github.com> Co-authored-by: WRadoslaw <r.wyszynski00@gmail.com> Co-authored-by: Artem <Artem Slugin> * Fix broken links (#3755) * Update collaborator id (#3760) * Fix issue with not being able to do dashboard actions (#3766) * fix inactive overlay loader (#3757) * fixed issue with not being able to scroll after sign up (#3764) * TnC and banners fix (#3769) * TnC copy changed (#3785) Co-authored-by: Artem <Artem Slugin> * Disallow submiting ypp form twice (#3790) * Add error snackbar about insufficient permission (#3801) * added insufficient permission snackbar * Fix issue with syncing tiles (#3787) * fix issue with logging unreadable error in console * fix issue with syncing tiles * handle insufficient permission properly (#3823) * Fix displaying wrong font color in VideoTileDetails (#3777) * fix displaying wrong font color in VideoTileDetails * Input caret color is barely visible on some backgrounds (#3695) * #2914 caret-color * caret color update (#2914) --------- Co-authored-by: Naman Anand <naman.anand@noema.net> * Turn off polling for publisher tiles (#3838) * disable polling for auto sync tiles * handle video created * Change scale for fullscreen video player (#3865) * 🦩 Clear button overflow fix (#3866) * Clear button overflow fix * Hide buttons when query is present * Show buttons when md match * 🉑 App actions (#3875) * Video creation part * Extract common logic to hook * Wrap channel creation into app action * Use hook in video creation context * Update to new playground (#3879) * update emv and schema * update categories * ✖️ Grouped design update (#3747) * Banner style update * NFT tile details style change * Popover style change * Button style update - Text only out of scope * Sidebar UI update * ToggleButtonGroup component * Add FilterButton component * Capitalize toggle options * Remove dependency circle * Slight ToggleButtonGroup rework * Change naming and hide button on end reached * Update collaborator member id (#3887) * update collaborat member id * update sync api url and collaborator * Fix typo in youtube backend url (#3888) * reset pagination on nft filter apply (#3883) * modified rawMetadataProcessor usage for updated orion queries (#3898) Co-authored-by: Artem <Artem Slugin> * Removed YPP videos from uploads Co-authored-by: Artem <Artem Slugin> * merge Joystream/master into Joystream/dev (#3901) - merge master * ytSynch thumbnails fix (#3903) * removed YPP videos from uploads, fixed uploading tiles (#3822) * fixed the unaccepted assets error for ytSynch videos --------- Co-authored-by: Artem <Artem Slugin> * Orion 2 integration (#3562) * update queries - wip * cleaning * add sorting to raw activities * prettier * Enable subscription support * fix channel and videos mutations * fix mutation errors * Fix AND-OR queries, ChannelLink and metaprotocol transaction handling, add Orion v2 dev server urls * fix some cache issues(timestamp, video views) * bring back development in env in store * rebuild schema, fix some cache problems * fix following channel * remove comment * fix category view * fix issue with displaying incorrect channel in edit video form * fix nft history and remove redundant owner info * refactor member activity * fix issue with not being able to accept bid * fix issue with from and to * fix notifications * fix new nft sales * fix owned nfts filters * remove comments * fix filters bug * fix cache errors * improve queryCacheFields, remove deprecated queries * regenerate graphql types * fix top10 queries, fix search view * fix filter in MemberView * fix issue with not getting correct comment events * fix issue with comments * fix bid-accepted notification * fix isUserSeller flag * fix ChannelAbout section * update orion url * update query node subscription url * use title_containsInsensitive in useSearchResult * fix channel searching * temporarly remove search queries, regenerate schema * cleaning * support custom queries, remove search.graphql * fix nft filters * fix query issues * use env variable in codegen config * remove batching comments * improve channel naming * fix config content filters * cr fixes * reduce polling interval for notifications * fix outbid notification * fix custom queries * use only memberId to get notifications * fix content filters, fix search, at least 4 videos * apply public filter to channel preview videos * fix other fitlers * fix channels in your language * update envs, config and rebuild schema * fix subscription url * fix category videos count * fix other filters hopefully 🙏🏻 * update env * introduce notification query * Introduce nftHistoryEntries query * introduce nft activities * update categories * fix activities sorting * improve comment notification * bring back previous notification arguments * update envs, add public filters for infinite grids * use resolvedUrl instead useAsset * fix playground * remove assets manager, remove distribution operators logic * set location header * replace resolved when isAccepted is false * add one more env, update orderBy for most popular --------- Co-authored-by: Lezek123 <leszek@jsgenesis.com> * fix env * rewrite GetChannelPaymentEvents * fix arguments * improvements * add correct orderBy * fix memberRemark, update types * disable ypp --------- Co-authored-by: WRadoslaw <92513933+WRadoslaw@users.noreply.github.com> Co-authored-by: attemka <attemka@gmail.com> Co-authored-by: Artem <Artem Slugin> Co-authored-by: Klaudiusz Dembler <accounts@kdembler.com> Co-authored-by: Rafał Pawłow <pawlow.rafal@gmail.com> Co-authored-by: Zeeshan Akram <37098720+zeeshanakram3@users.noreply.github.com> Co-authored-by: WRadoslaw <r.wyszynski00@gmail.com> Co-authored-by: Naman Anand <iamnamananand996@gmail.com> Co-authored-by: Naman Anand <naman.anand@noema.net> Co-authored-by: Lezek123 <leszek@jsgenesis.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3271