Skip to content

YPP LP PR review #3271

@toiletgranny

Description

@toiletgranny
  1. As is:width and height attributes are not specified on <img> elements.
    To be: They should be, so that layout shifts do not occur when the page is loading (this actually happened to me) and so that the SEO score of the page is higher.
  2. As is: <img> elements do not have alt attributes.
    To be: They should have. Let me know if you need help with those, happy to schedule a 15-30 minute call and do it together.
  3. As is: <button> elements don't have accessible names.
    To be: Ideally, and again — for SEO and accessibility purposes — they have. I believe this involves changing the component. Happy to discuss details over a call.
  4. As is: The fade gradient in Benefit card components goes down to var(--color-core-neutral-900) color.
    To be: It should be var(--color-core-neutral-800).
    CleanShot 2022-09-21 at 15 09 00
  5. As is: (Parallax) Different parts of product illustrations move in different directions and, sometimes, on different axes.
    To be: All parts of all product illustrations, ideally, move with the same speed, the same direction, and the along the same axis (vertically). This referees to the below illustrations:
    • "Upload your videos and own them like you mean it",
    • "New ways to engage and get support from your audience".
  6. As is: In the illustration for the "Monetize your videos with NFT sales and royalties" section, the NFT card component moves at the highest speed, the dropdown on top of it moves slightly slower, and the cursor above it all stays in place.
    To be: Ideally, the cursor moves the fastest, then there should be the dropdown, and — finally — the NFT card component, being the closest to the imaginary ground, should move the slowest of these three. Please, see the 1:1 benchmark here, in the "Monetise your videos with NFT sales and royalties" section.
  7. As is: All elements scrolled horizontally are clipped within boundaries of their parent containers.
    To be: They shouldn't be.
    CleanShot 2022-09-21 at 15 19 03
  8. I'm afraid the image compression is a bit too heavy for the kind of imagery we're using on this page. This is especially noticeable on gradient fades, like in the below example. Could we experiment with the compression intensity or type?
    image
  9. Nice-to-have ✨ If we have time allowance for this, I'd be super happy to jump on a quick call with whoever would be eager to add (as a cherry on top) simple on-scroll CSS entrance animations here and there, possibly using very simple and lightweight ready-made solutions such as the AOS or Animate.css libraries. Let me now!

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions