Protect proxy password by not storing it between sessions#9652
Merged
Conversation
Instead asks user for the password at the start of the program if they have enabled proxy with password.
Don't accept the pull request and start the testing when password changes have been implemented.
No ui changes in this commit, leaves password field empty on launch
…ered from JabRefGUI if proxy requires password
…hentication are enabled, before only auth was checked
(Feat): #1 Added test for storage of proxy preferences
(feat) #2 Adds pop-up asking for password at launch.
(Fix) #10 Removed dependency issue test functions
Member
|
Summarizing the requirements of the issue:
This PR addresses the "If no" case only. It does not address all the other requirements. Could you comment on your success investigating the libraries listed at #8055 (comment) - to handle requirements 2 and 4? I am not sure whether requirement 1 is easy to implement. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8055 by storing the proxy password only during run time and not in the system preferences. Also adds a pop-up at the start of the program if the user has checked "Use proxy" and "Use authentication" to allow them to enter the password for the proxy. An image of this pop-up can be seen below.
We considered using encryption to add extra security but were unsure if it was needed. What are your opinions on this?
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)