(Feat): #1 Added test for storage of proxy preferences#3
Merged
Conversation
Don't accept the pull request and start the testing when password changes have been implemented.
Collaborator
|
Seems the two if statements should be the other way around. Username and Password should be checked when user wants to use both proxy and authentication. |
Owner
|
LGTM |
jakobewaldsson
approved these changes
Mar 6, 2023
jakobewaldsson
left a comment
Collaborator
There was a problem hiding this comment.
Tests go through and looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't accept the pull request and start the testing when password changes have been implemented. I also have to clean this up but want all resources to still be there if adjustments have to be made to test.