Skip to content

(feat) #2 Adds pop-up asking for password at launch.#9

Merged
Darpos merged 4 commits into
fix-for-issue-8055from
Add-#2
Mar 6, 2023
Merged

(feat) #2 Adds pop-up asking for password at launch.#9
Darpos merged 4 commits into
fix-for-issue-8055from
Add-#2

Conversation

@JacobTrossing

Copy link
Copy Markdown
Owner

Adds a pop-up at the start of the program which asks the user for the password if they have checked that they want to use a proxy with password.

JacobTrossing and others added 4 commits March 1, 2023 14:28
 Instead asks user for the password at the start of the program if they
 have enabled proxy with password.
…ered from JabRefGUI if proxy requires password
…hentication are enabled, before only auth was checked
@Darpos Darpos self-requested a review March 6, 2023 08:39
@Darpos Darpos self-assigned this Mar 6, 2023
@Minhao037 Minhao037 self-requested a review March 6, 2023 08:41
@JacobTrossing JacobTrossing changed the title Add #2 (feat) #2 Adds pop-up asking for password at launch. Mar 6, 2023

@Minhao037 Minhao037 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Darpos Darpos left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me and looks good! Nice :)

@Darpos Darpos merged commit e4d4f45 into fix-for-issue-8055 Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants