Skip to content

Fixed various fetcher tests#9618

Merged
Siedlerchr merged 1 commit into
mainfrom
fix_fetch
Feb 14, 2023
Merged

Fixed various fetcher tests#9618
Siedlerchr merged 1 commit into
mainfrom
fix_fetch

Conversation

@calixtus

Copy link
Copy Markdown
Member
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

public void performSearchById() throws Exception {
BibEntry expected = new BibEntry()
.withField(StandardField.ADDRESS, "Burlington, MA")
.withField(StandardField.ADDRESS, "mau, Burlington, MA")

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks odd but well, if the fetcher return this...

@Siedlerchr Siedlerchr merged commit be34904 into main Feb 14, 2023
@Siedlerchr Siedlerchr deleted the fix_fetch branch February 14, 2023 19:13
Siedlerchr added a commit to NiD133/jabref that referenced this pull request Feb 25, 2023
* upstream/main: (78 commits)
  use optional
  remove empty lines and logger
  Simplify code, add test
  Show error only if user selected to store files in main directory
  Bump pascalgn/automerge-action from 0.15.5 to 0.15.6
  Update Gradle Wrapper from 7.6 to 8.0.1.
  add missing newlines at the end
  import strings and add them to the new bibdatabase Add test
  Resolve strings in MsOffice export
  Checkstyle
  Update CHANGELOG.md
  Refine error message and remove obsolete string
  Squashed 'buildres/csl/csl-styles/' changes from b111f31efe..9926b48cf3
  Fix storing multiline properties for custom fields in custom entry types
  Remove myself from MAINTAINERS (JabRef#9617)
  Fixed various fetcher tests (JabRef#9618)
  Fixed the performSearch Function
  Fix command line export for --exportMatches (JabRef#9610)
  Bump org.apache.commons:commons-csv from 1.9.0 to 1.10.0 (JabRef#9612)
  fix imports
  ...

# Conflicts:
#	CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants