Skip to content

Fix command line export for --exportMatches#9610

Merged
koppor merged 3 commits into
JabRef:mainfrom
aqurilla:fix-for-issue-9581
Feb 13, 2023
Merged

Fix command line export for --exportMatches#9610
koppor merged 3 commits into
JabRef:mainfrom
aqurilla:fix-for-issue-9581

Conversation

@aqurilla

Copy link
Copy Markdown
Contributor

This fixes #9581 by creating an export bib file when the bib export format is specified, or when there is no specified export format.

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@aqurilla aqurilla marked this pull request as ready for review February 12, 2023 05:35
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Feb 12, 2023
@Siedlerchr

Copy link
Copy Markdown
Member

Thank, codewie looks already good! Will test this later

@aqurilla

Copy link
Copy Markdown
Contributor Author

Thanks, appreciate it!

Siedlerchr
Siedlerchr previously approved these changes Feb 12, 2023
@Siedlerchr

Copy link
Copy Markdown
Member

Please add a changelog entry!

@koppor koppor merged commit 4e30b97 into JabRef:main Feb 13, 2023
@Siedlerchr

Copy link
Copy Markdown
Member

Thanks for the very good work! This and the other PR were both good!

@aqurilla

Copy link
Copy Markdown
Contributor Author

Great to hear that, thanks!

Siedlerchr added a commit to NiD133/jabref that referenced this pull request Feb 25, 2023
* upstream/main: (78 commits)
  use optional
  remove empty lines and logger
  Simplify code, add test
  Show error only if user selected to store files in main directory
  Bump pascalgn/automerge-action from 0.15.5 to 0.15.6
  Update Gradle Wrapper from 7.6 to 8.0.1.
  add missing newlines at the end
  import strings and add them to the new bibdatabase Add test
  Resolve strings in MsOffice export
  Checkstyle
  Update CHANGELOG.md
  Refine error message and remove obsolete string
  Squashed 'buildres/csl/csl-styles/' changes from b111f31efe..9926b48cf3
  Fix storing multiline properties for custom fields in custom entry types
  Remove myself from MAINTAINERS (JabRef#9617)
  Fixed various fetcher tests (JabRef#9618)
  Fixed the performSearch Function
  Fix command line export for --exportMatches (JabRef#9610)
  Bump org.apache.commons:commons-csv from 1.9.0 to 1.10.0 (JabRef#9612)
  fix imports
  ...

# Conflicts:
#	CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Command line export does not create an output bib file

3 participants