Skip to content

Fixes fetcher tests#9175

Merged
Siedlerchr merged 1 commit into
mainfrom
fix-tests
Sep 24, 2022
Merged

Fixes fetcher tests#9175
Siedlerchr merged 1 commit into
mainfrom
fix-tests

Conversation

@koppor

@koppor koppor commented Sep 23, 2022

Copy link
Copy Markdown
Member

This fixes the fetcher tests (and uses JabRef's builder pattern)

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor koppor added component: fetcher status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers labels Sep 23, 2022

@calixtus calixtus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful

@Siedlerchr Siedlerchr merged commit 4b013c3 into main Sep 24, 2022
@Siedlerchr Siedlerchr deleted the fix-tests branch September 24, 2022 08:43
Siedlerchr added a commit to LIM0000/jabref that referenced this pull request Oct 3, 2022
* upstream/main: (27 commits)
  Bump slf4j-api from 2.0.2 to 2.0.3 (JabRef#9207)
  Bump slf4j-api from 2.0.2 to 2.0.3 in /buildSrc (JabRef#9211)
  Add mappings on ModsImporter.java (JabRef#9193)
  Improve installation of java 18 in devcontainer (JabRef#9197)
  Fix missing title for "customize entry types" (JabRef#9198) (JabRef#9201)
  Squashed 'buildres/csl/csl-locales/' changes from b2afeb4d87..cb98d36691
  Squashed 'buildres/csl/csl-styles/' changes from 201e022..7bde3e4
  "Capitalize" capitalizes words after hyphens (JabRef#9186)
  Observable Preferences O (Language and FileHistory) (JabRef#9173)
  Fix jakarta annotation missing (JabRef#9183)
  Bump junit-platform-launcher from 1.9.0 to 1.9.1 (JabRef#9177)
  Bump WyriHaximus/github-action-wait-for-status from 1.6 to 1.7.1 (JabRef#9178)
  Bump junit-jupiter from 5.9.0 to 5.9.1 (JabRef#9180)
  Bump checkstyle from 10.3.3 to 10.3.4 (JabRef#9179)
  Bump slf4j-api from 2.0.1 to 2.0.2 (JabRef#9181)
  Bump slf4j-api from 2.0.1 to 2.0.2 in /buildSrc (JabRef#9182)
  Remove Java Flight Recorder (JabRef#9174)
  Fixes fetcher tests (JabRef#9175)
  Update afterburner to jakarta (JabRef#9168)
  Improve startup-behavior of pdf indexer (JabRef#9166)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: fetcher status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants