Remove Java Flight Recorder#9174
Merged
Merged
Conversation
Member
|
I thought the open jdk version is free to use |
Member
Author
In case you have source for that? Maybe, its the client tooling accessing the JFR data. I don't use profiling tooling in my daily work with JabRef. I perceived that we as group do profiling "on demand" when we concentrate on memory consumption etc. For this case, we are free to re-use any module required to do that. - However, in 99,99% of the usages of JabRef, the modules is NOT used. Furthermore, using the module prevents us to switch to other JDKs. Not OpenJ9 and IMHO also not GraalVM. Further, removing the module makes the distrubtion size smaller and gains a (small) bit of performance. |
Siedlerchr
added a commit
to LIM0000/jabref
that referenced
this pull request
Oct 3, 2022
* upstream/main: (27 commits) Bump slf4j-api from 2.0.2 to 2.0.3 (JabRef#9207) Bump slf4j-api from 2.0.2 to 2.0.3 in /buildSrc (JabRef#9211) Add mappings on ModsImporter.java (JabRef#9193) Improve installation of java 18 in devcontainer (JabRef#9197) Fix missing title for "customize entry types" (JabRef#9198) (JabRef#9201) Squashed 'buildres/csl/csl-locales/' changes from b2afeb4d87..cb98d36691 Squashed 'buildres/csl/csl-styles/' changes from 201e022..7bde3e4 "Capitalize" capitalizes words after hyphens (JabRef#9186) Observable Preferences O (Language and FileHistory) (JabRef#9173) Fix jakarta annotation missing (JabRef#9183) Bump junit-platform-launcher from 1.9.0 to 1.9.1 (JabRef#9177) Bump WyriHaximus/github-action-wait-for-status from 1.6 to 1.7.1 (JabRef#9178) Bump junit-jupiter from 5.9.0 to 5.9.1 (JabRef#9180) Bump checkstyle from 10.3.3 to 10.3.4 (JabRef#9179) Bump slf4j-api from 2.0.1 to 2.0.2 (JabRef#9181) Bump slf4j-api from 2.0.1 to 2.0.2 in /buildSrc (JabRef#9182) Remove Java Flight Recorder (JabRef#9174) Fixes fetcher tests (JabRef#9175) Update afterburner to jakarta (JabRef#9168) Improve startup-behavior of pdf indexer (JabRef#9166) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes Java Flight Recorder
I think, we never used it on a user's side, so would remove it for our distribution.
On a case-per-case-basis, we (or some researchers) could include
jdk.jfrback locally.CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)