Skip to content

SLR data is now editable#9131

Merged
Siedlerchr merged 15 commits into
mainfrom
make-study-edititable
Sep 4, 2022
Merged

SLR data is now editable#9131
Siedlerchr merged 15 commits into
mainfrom
make-study-edititable

Conversation

@koppor

@koppor koppor commented Sep 3, 2022

Copy link
Copy Markdown
Member

About this PR

This PR adds actions to edit an SLR and adds other refinements.

When SLR is selected:

grafik

When no SLR is selected:

grafik

Open issues

  • When managing an SLR, there should not be the "Start" button, but the "Save" button
  • User testing

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Comment thread src/main/java/org/jabref/gui/slr/StartNewStudyAction.java Outdated
Comment thread src/main/java/org/jabref/gui/slr/StartNewStudyAction.java Outdated
Comment thread src/main/java/org/jabref/gui/slr/EditExistingStudyAction.java Outdated
koppor and others added 8 commits September 4, 2022 01:48
* upstream/main:
  Fix link and remove obsolete FAQ
  Rename 'Close' to 'Cancel' in the External Changes Resolver dialog (#9130)
  Tiny rephrasing
  Linked files with an absolute path can be opened again (#9129)
  Oberservable Preferences M (CleanupPreferences) (#9126)
  fix broken link
  Fix broken link
  Fix old JabRef linked files containing the file directory as element in the filename (#9046)
  PDFs are not stored next to .bib file if file directory is configured (#9113)
  Remove double stateManager.activeDatabaseProperty() (#9127)
  Don't show the info button when the authors field content is identical (#9128)
- SLR main branch is now "main" (instead of "master")
- SLR git initalization now has the .gitignore in the initial commit
- Localization
  - Change from "Perform search for existing systematic literature review" to "Update study search results"
  - Group together saving localization
  - Refine localization for LyX
  - Fix typo "case-insensitive" (source https://en.wikipedia.org/wiki/Case_sensitivity)
Comment thread src/main/java/org/jabref/gui/slr/ExistingStudySearchAction.java
Comment thread src/main/java/org/jabref/gui/slr/ManageStudyDefinitionViewModel.java Outdated
@koppor koppor marked this pull request as ready for review September 4, 2022 14:20
Comment thread src/main/java/org/jabref/gui/slr/EditExistingStudyAction.java Outdated
@Siedlerchr Siedlerchr merged commit b06e4dc into main Sep 4, 2022
@Siedlerchr Siedlerchr deleted the make-study-edititable branch September 4, 2022 14:46
Siedlerchr added a commit that referenced this pull request Sep 4, 2022
* upstream/main:
  Resimplify Action interface (#9133)
  Fix issue with empty fallback directory (#9134)
  Fix indexing (#9132)
  SLR data is now editable (#9131)
Siedlerchr added a commit to LIM0000/jabref that referenced this pull request Sep 10, 2022
* upstream/main:
  Anomaly with Title case and Sentence case JabRef#9112 (JabRef#9142)
  Fixed save order config (JabRef#9148)
  Update devdocs about fetchers (JabRef#9146)
  Set 'Update refused' dialog title (JabRef#9143)
  Bump jackson-datatype-jsr310 from 2.13.3 to 2.13.4 (JabRef#9136)
  Bump jackson-dataformat-yaml from 2.13.3 to 2.13.4 (JabRef#9138)
  Observable Preferences N (PushToApplicationPreferences, ExternalApplicationPreferences) (JabRef#9135)
  Resimplify Action interface (JabRef#9133)
  Fix issue with empty fallback directory (JabRef#9134)
  Fix indexing (JabRef#9132)
  SLR data is now editable (JabRef#9131)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable modification of SLR properties When start and end of SLR: popup

2 participants