PDFs are not stored next to .bib file if file directory is configured by koppor · Pull Request #9113 · JabRef/jabref

koppor · 2022-09-01T21:59:26Z

We had following issue:

database file directory is configured outside the .bib directory
.bib file is versioned
.bib file is shared among a research group
a user constantly adds PDFs into the git repository

Inspecting the code, the reason probably is that the database file directory is accessible on Windows only, but not on Mac OS X. Thus, during download, JabRef did a fallback on the directory of the .bib file.

This PR fixes it:

In case a directory is set for a database, the fallback is NOT the directory of the .bib file, but the globally configured directory
The globally configured directory is empty per default. The new default is the user's home + JabRef sub directory:

Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
Tests created for changes (if applicable)
Manually tested changed features in running JabRef (always required)
Screenshots added in PR description (for UI changes)
Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

…ectory. Co-authored-by: Kevin Klein <kevin@0x002a.com>

… "JabRef" in the user's home Co-authored-by: Kevin Klein <kevin@0x002a.com>

Co-authored-by: Kevin Klein <kevin@0x002a.com>

Siedlerchr · 2022-09-02T08:18:34Z

How does this correlate with the Checkbox ticked "Search and store files relative to the bib library directory?"
=> If all direcroties are empty and this is checked then the file should be stored next to the bib file

koppor · 2022-09-02T14:04:16Z

How does this correlate with the Checkbox ticked "Search and store files relative to the bib library directory?" => If all direcroties are empty and this is checked then the file should be stored next to the bib file

This is the long description of following new (!) code:

   if (fileDirs.isEmpty() && preferences.shouldStoreFilesRelativeToBibFile()) {

Should I add this as text or would it be clear from the code itself?

…ser-directory-first # Conflicts: # CHANGELOG.md

calixtus · 2022-09-03T09:00:54Z

Major problem: swing reintroduced in JabRefPreferences, architecture tests are failing and future modularization is at risk

Siedlerchr · 2022-09-03T10:02:40Z

Deciscions: Move to OS or Desktop class

…-user-directory-first * upstream/main: fix l10n Compile fix Fix parsing of JabRef v5.7 study.yml files (#9124) Fix integrity check for tilde accents in author names (#9097) Rework the Define study parameters dialog (#9123) # Conflicts: # CHANGELOG.md

remove obsolete checks

Siedlerchr · 2022-09-03T18:28:00Z

CleanupWorker fails cleanupRenamePdfRenamesRelativeFile and cleanupRelativePathsConvertAbsoluteToRelativePath

This reverts commit 279ae2e.

Co-authored-by: Christoph <siedlerkiller@gmail.com>

* upstream/main: Fix link and remove obsolete FAQ Rename 'Close' to 'Cancel' in the External Changes Resolver dialog (#9130) Tiny rephrasing Linked files with an absolute path can be opened again (#9129) Oberservable Preferences M (CleanupPreferences) (#9126) fix broken link Fix broken link Fix old JabRef linked files containing the file directory as element in the filename (#9046) PDFs are not stored next to .bib file if file directory is configured (#9113) Remove double stateManager.activeDatabaseProperty() (#9127) Don't show the info button when the authors field content is identical (#9128)

* upstream/main: (111 commits) Fix link and remove obsolete FAQ Rename 'Close' to 'Cancel' in the External Changes Resolver dialog (JabRef#9130) Tiny rephrasing Linked files with an absolute path can be opened again (JabRef#9129) Oberservable Preferences M (CleanupPreferences) (JabRef#9126) fix broken link Fix broken link Fix old JabRef linked files containing the file directory as element in the filename (JabRef#9046) PDFs are not stored next to .bib file if file directory is configured (JabRef#9113) Remove double stateManager.activeDatabaseProperty() (JabRef#9127) Don't show the info button when the authors field content is identical (JabRef#9128) "study.yml" is static now (JabRef#9125) fix l10n Compile fix Fix parsing of JabRef v5.7 study.yml files (JabRef#9124) Fix integrity check for tilde accents in author names (JabRef#9097) Rework the Define study parameters dialog (JabRef#9123) Fix parsing of save actions (JabRef#9122) Fix exception that occurs when saving name formatters (JabRef#9121) Refine code for BibEntry#replaceDownloadedFile (JabRef#9118) ...

koppor and others added 7 commits September 1, 2022 23:17

Fix typos

fcf678e

Add comment

4143b1d

FileLinkPreferences now rely on FilePreferences

44625f9

The fallback directory of the file folder now is the general file dir…

7406d49

…ectory. Co-authored-by: Kevin Klein <kevin@0x002a.com>

Improve LOGGER call with {}

963a3a6

The global default directory for storing PDFs is now the subdirectory…

75e6680

… "JabRef" in the user's home Co-authored-by: Kevin Klein <kevin@0x002a.com>

Adapt tests to new behavior

bce2253

Co-authored-by: Kevin Klein <kevin@0x002a.com>

koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Sep 2, 2022

koppor added 5 commits September 3, 2022 00:56

Refine comment

c9656ff

Try to fix checkstyle

50d73e7

Merge remote-tracking branch 'origin/main' into download-should-use-u…

795c5e5

…ser-directory-first # Conflicts: # CHANGELOG.md

Fix typo

3b14a86

Fix "illegal unicode escape"

caf101a

Siedlerchr added 2 commits September 3, 2022 18:46

Add architecture test and move to java desktop

eb89970

remove obsolete checks

github-actions Bot reviewed Sep 3, 2022

View reviewed changes

Comment thread src/main/java/org/jabref/gui/desktop/JabRefDesktop.java

Add missing class

0422f52

Siedlerchr added 2 commits September 3, 2022 20:39

remove check for empty file dirs

279ae2e

fix tests

2c0e172

github-actions Bot reviewed Sep 3, 2022

View reviewed changes

Comment thread src/test/java/org/jabref/model/database/BibDatabaseContextTest.java

Siedlerchr and others added 4 commits September 3, 2022 21:09

Fix checkstye

954d276

fix copy paste error

21819e8

Revert "remove check for empty file dirs"

47ac561

This reverts commit 279ae2e.

Fix tests

da9d81a

Co-authored-by: Christoph <siedlerkiller@gmail.com>

Siedlerchr merged commit 4685800 into main Sep 3, 2022

Siedlerchr deleted the download-should-use-user-directory-first branch September 3, 2022 19:58

Siedlerchr mentioned this pull request Sep 4, 2022

Fix issue with empty fallback directory #9134

Merged

6 tasks

calixtus added the project: jabcon label Sep 4, 2022

This was referenced Oct 5, 2022

Process CLI arguments before starting gui #9217

Merged

Removed swing from default file dir detection #9222

Merged

ThiloteE mentioned this pull request Jan 13, 2023

Main file directory is used if not empty, even if deactivated #9556

Closed

2 tasks

Siedlerchr mentioned this pull request Feb 18, 2023

Refine main directory not found error message #9625

Merged

6 tasks

koppor mentioned this pull request Jul 15, 2024

Fix handling of relative-file storage and auto linking #11492

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

PDFs are not stored next to .bib file if file directory is configured#9113

PDFs are not stored next to .bib file if file directory is configured#9113
Siedlerchr merged 21 commits into
mainfrom
download-should-use-user-directory-first

koppor commented Sep 1, 2022

Uh oh!

Siedlerchr commented Sep 2, 2022

Uh oh!

koppor commented Sep 2, 2022

Uh oh!

calixtus commented Sep 3, 2022

Uh oh!

Siedlerchr commented Sep 3, 2022

Uh oh!

Uh oh!

Siedlerchr commented Sep 3, 2022

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

koppor commented Sep 1, 2022

Uh oh!

Siedlerchr commented Sep 2, 2022

Uh oh!

koppor commented Sep 2, 2022

Uh oh!

calixtus commented Sep 3, 2022

Uh oh!

Siedlerchr commented Sep 3, 2022

Uh oh!

Uh oh!

Siedlerchr commented Sep 3, 2022

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants