Skip to content

Fix subdatabase from aux on cli#9117

Merged
Siedlerchr merged 6 commits into
mainfrom
auxCliTest
Sep 2, 2022
Merged

Fix subdatabase from aux on cli#9117
Siedlerchr merged 6 commits into
mainfrom
auxCliTest

Conversation

@Siedlerchr

@Siedlerchr Siedlerchr commented Sep 2, 2022

Copy link
Copy Markdown
Member

Fix database writer not closed

Add test for aux files
Fixes #9115

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Add test for aux files
Comment thread src/test/java/org/jabref/cli/ArgumentProcessorTest.java
Comment thread src/test/java/org/jabref/cli/ArgumentProcessorTest.java
Comment thread src/test/java/org/jabref/cli/ArgumentProcessorTest.java
Comment thread src/test/java/org/jabref/cli/ArgumentProcessorTest.java
Comment thread src/test/java/org/jabref/cli/ArgumentProcessorTest.java
Comment thread src/test/java/org/jabref/cli/ArgumentProcessorTest.java
@Siedlerchr Siedlerchr changed the title WIP: Fix Aux file writing from cli Fix subdatabase from aux on cli Sep 2, 2022
* upstream/main:
  Visual improvements to LinkedFilesEditor (#9114)
  SLR Remove "last-search-date" (#9116)
  Hide diffs when one of the field values is blank a.k.a no conflict (#9110)
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Sep 2, 2022
Comment thread CHANGELOG.md Outdated

@0x002A 0x002A left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Siedlerchr Siedlerchr merged commit 5a34184 into main Sep 2, 2022
@Siedlerchr Siedlerchr deleted the auxCliTest branch September 2, 2022 15:16
Siedlerchr added a commit that referenced this pull request Sep 2, 2022
* upstream/main: (387 commits)
  Show a warning in the merge dialog when authors are the same but formatted differently (#9088)
  Fix subdatabase from aux on cli (#9117)
  Visual improvements to LinkedFilesEditor (#9114)
  SLR Remove "last-search-date" (#9116)
  Hide diffs when one of the field values is blank a.k.a no conflict (#9110)
  Squashed 'buildres/csl/csl-locales/' changes from e637746677..b2afeb4d87
  Squashed 'buildres/csl/csl-styles/' changes from c750b6e..8d69f16
  Fix title case capitalization after en-dash characters (#9102)
  Update journal abbrev list (#9109)
  Fix CSL rendering in case of article (#8607)
  [WIP][GSOC22] - C - Improve the external changes resolver dialog (#9021)
  Bump jsoup from 1.15.1 to 1.15.3 (#9103)
  Bump checkstyle from 10.3.2 to 10.3.3 (#9104)
  Bump postgresql from 42.4.2 to 42.5.0 (#9105)
  Bump unirest-java from 3.13.10 to 3.13.11 (#9106)
  Include check for TimeStamp (#9089)
  Close OO connection on JabRef exit (#9076)
  Bump slf4j-tinylog from 2.4.1 to 2.5.0 (#9085)
  Bump bcprov-jdk18on from 1.71 to 1.71.1 (#9079)
  Bump tinylog-impl from 2.4.1 to 2.5.0 (#9086)
  ...

# Conflicts:
#	src/main/java/org/jabref/gui/shared/SharedDatabaseUIManager.java
#	src/main/java/org/jabref/gui/util/DefaultTaskExecutor.java
#	src/main/java/org/jabref/logic/shared/DBMSSynchronizer.java
Siedlerchr added a commit that referenced this pull request Sep 3, 2022
…nto linkedFilesfixesRelative

* 'linkedFilesfixesRelative' of github.com:JabRef/jabref: (52 commits)
  Enable files/files
  Don't show the info button when the authors field content is identical (#9128)
  "study.yml" is static now (#9125)
  fix l10n
  Compile fix
  Fix parsing of JabRef v5.7 study.yml files (#9124)
  Fix integrity check  for tilde accents in author names (#9097)
  Rework the Define study parameters dialog (#9123)
  Fix parsing of save actions (#9122)
  Fix exception that occurs when saving name formatters (#9121)
  Refine code for BibEntry#replaceDownloadedFile (#9118)
  Show a warning in the merge dialog when authors are the same but formatted differently (#9088)
  Fix subdatabase from aux on cli (#9117)
  Visual improvements to LinkedFilesEditor (#9114)
  SLR Remove "last-search-date" (#9116)
  Hide diffs when one of the field values is blank a.k.a no conflict (#9110)
  Squashed 'buildres/csl/csl-locales/' changes from e637746677..b2afeb4d87
  Squashed 'buildres/csl/csl-styles/' changes from c750b6e..8d69f16
  Fix title case capitalization after en-dash characters (#9102)
  Update journal abbrev list (#9109)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

project: jabcon status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Command line export for subdatabase creates empty bib file

4 participants