Skip to content

Close OO connection on JabRef exit#9076

Merged
Siedlerchr merged 5 commits into
mainfrom
ooCloseCon
Aug 22, 2022
Merged

Close OO connection on JabRef exit#9076
Siedlerchr merged 5 commits into
mainfrom
ooCloseCon

Conversation

@Siedlerchr

@Siedlerchr Siedlerchr commented Aug 21, 2022

Copy link
Copy Markdown
Member

Fixes #9075

Closes the OO-Bridge when JabRef exits. If none is open, nothing happens. Otherwise the bridge is closed, JabRef exits but the LO document stays open

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Comment thread src/main/java/org/jabref/gui/openoffice/OOBibBaseConnect.java
Fixes #9075
JabRef exits now, LO document is kept open
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Aug 21, 2022
* upstream/main:
  Bump slf4j-tinylog from 2.4.1 to 2.5.0 (#9085)
  Bump bcprov-jdk18on from 1.71 to 1.71.1 (#9079)
  Bump tinylog-impl from 2.4.1 to 2.5.0 (#9086)
  Bump postgresql from 42.4.1 to 42.4.2 (#9081)
  Bump slf4j-api from 2.0.0-beta1 to 2.0.0 in /buildSrc (#9083)
  Bump unoloader from 7.3.5 to 7.4.0 (#9084)
  Bump slf4j-api from 2.0.0-beta1 to 2.0.0 (#9078)
  Bump tinylog-api from 2.4.1 to 2.5.0 (#9080)
  Bump libreoffice from 7.3.5 to 7.4.0 (#9082)
  Bump hmarr/auto-approve-action from 2.2.1 to 2.4.0 (#9077)

@calixtus calixtus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@koppor koppor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two nitpicks. Then LGTM.

Comment thread src/main/java/org/jabref/gui/openoffice/OOBibBaseConnect.java Outdated
Comment thread src/main/java/org/jabref/gui/openoffice/OOBibBaseConnect.java Outdated
Siedlerchr and others added 2 commits August 22, 2022 21:47
Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>
Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>
@Siedlerchr Siedlerchr merged commit a255311 into main Aug 22, 2022
@Siedlerchr Siedlerchr deleted the ooCloseCon branch August 22, 2022 19:58
Siedlerchr added a commit that referenced this pull request Sep 2, 2022
* upstream/main: (387 commits)
  Show a warning in the merge dialog when authors are the same but formatted differently (#9088)
  Fix subdatabase from aux on cli (#9117)
  Visual improvements to LinkedFilesEditor (#9114)
  SLR Remove "last-search-date" (#9116)
  Hide diffs when one of the field values is blank a.k.a no conflict (#9110)
  Squashed 'buildres/csl/csl-locales/' changes from e637746677..b2afeb4d87
  Squashed 'buildres/csl/csl-styles/' changes from c750b6e..8d69f16
  Fix title case capitalization after en-dash characters (#9102)
  Update journal abbrev list (#9109)
  Fix CSL rendering in case of article (#8607)
  [WIP][GSOC22] - C - Improve the external changes resolver dialog (#9021)
  Bump jsoup from 1.15.1 to 1.15.3 (#9103)
  Bump checkstyle from 10.3.2 to 10.3.3 (#9104)
  Bump postgresql from 42.4.2 to 42.5.0 (#9105)
  Bump unirest-java from 3.13.10 to 3.13.11 (#9106)
  Include check for TimeStamp (#9089)
  Close OO connection on JabRef exit (#9076)
  Bump slf4j-tinylog from 2.4.1 to 2.5.0 (#9085)
  Bump bcprov-jdk18on from 1.71 to 1.71.1 (#9079)
  Bump tinylog-impl from 2.4.1 to 2.5.0 (#9086)
  ...

# Conflicts:
#	src/main/java/org/jabref/gui/shared/SharedDatabaseUIManager.java
#	src/main/java/org/jabref/gui/util/DefaultTaskExecutor.java
#	src/main/java/org/jabref/logic/shared/DBMSSynchronizer.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: libre-office status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

App hang on exit on macOS

4 participants