Skip to content

Introduce preference to disable fulltext indexing#8478

Merged
Siedlerchr merged 3 commits into
mainfrom
fulltextIndexToggle
Jan 31, 2022
Merged

Introduce preference to disable fulltext indexing#8478
Siedlerchr merged 3 commits into
mainfrom
fulltextIndexToggle

Conversation

@btut

@btut btut commented Jan 31, 2022

Copy link
Copy Markdown
Contributor

Fulltext indexing can take up lots of resources on big libraries. This PR introduces a preference to disable it.
This is particularly important if JabRef struggles to determine if a linked file was updated since it was indexed (e.g. when using a library on a shared network drive without 'modified' timestamps)
image

Fixes #8468

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jan 31, 2022
Siedlerchr
Siedlerchr reviewed Jan 31, 2022
View reviewed changes
Comment thread src/main/java/org/jabref/gui/preferences/linkedfiles/LinkedFilesTab.fxml Outdated
<Button fx:id="autolinkRegexHelp"/>
</HBox>

<Label styleClass="sectionHeader" text="%Fulltext-Index linked files"/>

@Siedlerchr Siedlerchr Jan 31, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just name the section header "Fulltext Index"

@Siedlerchr

Siedlerchr commented Jan 31, 2022

Copy link
Copy Markdown
Member

lgtm

@Siedlerchr Siedlerchr merged commit c1c79a0 into main Jan 31, 2022
@Siedlerchr Siedlerchr deleted the fulltextIndexToggle branch January 31, 2022 20:15
Siedlerchr added a commit that referenced this pull request Feb 4, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into dependabot/gradle/o…
1fa8dd9 
…rg.mariadb.jdbc-mariadb-java-client-3.0.3

* upstream/main:
  Introduce preference to disable fulltext indexing (#8478)
  Upgrade to jdk 17 (#8433)
  Fix for DOI copy issues (#8471)
  Bump xmlunit-matchers from 2.8.4 to 2.9.0 (#8479)
  Bump checkstyle from 9.2.1 to 9.3 (#8480)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Siedlerchr Siedlerchr Siedlerchr left review comments

Assignees

No one assigned

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cancel index background worker when exiting JabRef

3 participants

@btut @Siedlerchr @koppor