Skip to content

Upgrade to jdk 17#8433

Merged
Siedlerchr merged 10 commits into
mainfrom
jdk17
Jan 31, 2022
Merged

Upgrade to jdk 17#8433
Siedlerchr merged 10 commits into
mainfrom
jdk17

Conversation

@calixtus

@calixtus calixtus commented Jan 17, 2022

Copy link
Copy Markdown
Member

Can you try this please on your machine?

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@calixtus calixtus added dev: build-system status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers labels Jan 17, 2022
tobiasdiez
tobiasdiez reviewed Jan 17, 2022
View reviewed changes
Comment thread build.gradle
@calixtus

calixtus commented Jan 17, 2022

Copy link
Copy Markdown
Member Author

This PR should not be merged, before we are sure that UNIBAS-SE does not need us to stay at JDK 16 anymore.

@Siedlerchr
Merge remote-tracking branch 'upstream/main' into jdk17
4db7cee 
* upstream/main:
  Bump libreoffice from 7.2.3 to 7.2.5 (#8436)
  Bump org.openjfx.javafxplugin from 0.0.10 to 0.0.11 (#8437)
@Siedlerchr

Siedlerchr commented Jan 17, 2022

Copy link
Copy Markdown
Member

We should switch from adopt to temurin, since that is the new name (I hate those name changes) because it might be that the adopt name at one point in the future does no longer work.

https://blog.adoptopenjdk.net/2021/08/goodbye-adoptopenjdk-hello-adoptium/
Otherwise lgtm, the changes work in Eclipse as well

koppor
koppor approved these changes Jan 20, 2022
View reviewed changes

@koppor koppor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, LGTM - one micro nitpick

Comment thread gradle/wrapper/gradle-wrapper.properties
@@ -1,6 +1,5 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionSha256Sum=b586e04868a22fd817c8971330fec37e298f3242eb85c374181b12d637f80302

@koppor koppor Jan 20, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't the checksum of the binary be kept?

@calixtus calixtus Jan 20, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not remember removing it. @Siedlerchr is to blame for 5d405cb
😉

@Siedlerchr Siedlerchr Jan 21, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just updated gradlew to the latest version, there was somehow a merge conflict or whatever

@calixtus calixtus Jan 22, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, bit that means the checksum has changed?

@Siedlerchr Siedlerchr Jan 28, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refs the discussion here: gradle/gradle#12412 (comment)
Apparently, when you don't include the parameter it gets deleted.

@Siedlerchr
Merge remote-tracking branch 'upstream/main' into jdk17
84a2d78 
* upstream/main: (24 commits)
  Support CrossRef in CSL styles (#8454)
  Update FUNDING.yml (#8473)
  Update to Javafx 17.02 (#8470)
  Made search button in Web search wider. Also skewed side panel titles to the left (#8463)
  Bump h2-mvstore from 2.0.206 to 2.1.210 in /buildSrc (#8458)
  Bump mariadb-java-client from 2.7.4 to 2.7.5 (#8457)
  Bump com.github.andygoossens.modernizer from 1.6.1 to 1.6.2 (#8459)
  Bump mockito-core from 4.2.0 to 4.3.0 (#8460)
  Bump xmlunit-matchers from 2.8.3 to 2.8.4 (#8461)
  Improve error handling for browser extension (#8432)
  New Crowdin updates (#8451)
  Fix library tab exception when saving prefs (#8450)
  Rename Groups interface into Groups (#8449)
  New Crowdin updates (#8445)
  update snap url
  Update bug_report.yml for 5.5
  Show development information\n\n+semver: minor
  Release v5.5
  Update journal abbrev list
  New Crowdin updates (#8439)
  ...
@Siedlerchr
readd binary checksum
51c08a3
@Siedlerchr Siedlerchr merged commit a8a6129 into main Jan 31, 2022
@Siedlerchr Siedlerchr deleted the jdk17 branch January 31, 2022 19:50
Siedlerchr added a commit that referenced this pull request Feb 4, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into dependabot/gradle/o…
1fa8dd9 
…rg.mariadb.jdbc-mariadb-java-client-3.0.3

* upstream/main:
  Introduce preference to disable fulltext indexing (#8478)
  Upgrade to jdk 17 (#8433)
  Fix for DOI copy issues (#8471)
  Bump xmlunit-matchers from 2.8.4 to 2.9.0 (#8479)
  Bump checkstyle from 9.2.1 to 9.3 (#8480)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Siedlerchr Siedlerchr Siedlerchr left review comments

@tobiasdiez tobiasdiez tobiasdiez left review comments

@koppor koppor koppor approved these changes

Assignees

No one assigned

Labels

dev: build-system status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@calixtus @Siedlerchr @koppor @tobiasdiez