Observable Preferences H (WorkingDir, getUser, NameFormatter, Version, SpecialFields)#8260
Merged
Conversation
Member
Author
|
Failing unit test org.jabref.logic.importer.fileformat.PdfMergeMetadataImporterTest should be fixed in #8262 |
Siedlerchr
reviewed
Nov 21, 2021
| } | ||
|
|
||
| private void createMainTable() { | ||
| bibDatabaseContext.getDatabase().registerListener(SpecialFieldDatabaseChangeListener.INSTANCE); |
Member
There was a problem hiding this comment.
This listener is no longer used?
Member
Author
There was a problem hiding this comment.
SpecialFieldDatabaseChangeListener was part of the autosync complex. we removed it last year, but there were still some artifacts floating around.
Siedlerchr
reviewed
Nov 21, 2021
Siedlerchr
reviewed
Nov 21, 2021
Siedlerchr
left a comment
Member
There was a problem hiding this comment.
lgtm, just the l10n linebrak seems off
Siedlerchr
approved these changes
Nov 22, 2021
Siedlerchr
added a commit
that referenced
this pull request
Nov 22, 2021
* upstream/main: Observable Preferences H (WorkingDir, getUser, NameFormatter, Version, SpecialFields) (#8260) Bump checkstyle from 9.0.1 to 9.1 (#8266) Bump mockito-core from 4.0.0 to 4.1.0 (#8267) Bump classgraph from 4.8.130 to 4.8.135 (#8268) Fix some fetcher tests (#8258) Clicking a DOI link in the preview pane no longer crashes (#8255)
Siedlerchr
added a commit
that referenced
this pull request
Nov 30, 2021
* upstream/main: Consider directory pattern when checking if a file can be moved (#8244) Bump byte-buddy-parent from 1.12.1 to 1.12.2 (#8285) Bump unirest-java from 3.13.3 to 3.13.4 (#8283) Bump checkstyle from 9.1 to 9.2 (#8284) Bump classgraph from 4.8.135 to 4.8.137 (#8282) Do not resize main table columns in search dialog window (#8253) Fix NegativeArraySizeException (#8270) Update deployment.yml TEst Grand unified library properties (GRULPS) (#8264) Fixes RFC fetcher test case (#8271) Update Gradle Wrapper from 7.2 to 7.3 (#8246) Observable Preferences H (WorkingDir, getUser, NameFormatter, Version, SpecialFields) (#8260) Bump checkstyle from 9.0.1 to 9.1 (#8266) Bump mockito-core from 4.0.0 to 4.1.0 (#8267) Bump classgraph from 4.8.130 to 4.8.135 (#8268) Fix some fetcher tests (#8258) Clicking a DOI link in the preview pane no longer crashes (#8255)
Siedlerchr
added a commit
that referenced
this pull request
Dec 4, 2021
* upstream/main: (259 commits) Fix exception on preview style edit and selection (#8293) Fix icon picker excpetion in groups dialog (#8290) Add doc tests (#8242) fix merge conflict Squashed 'buildres/csl/csl-locales/' changes from 0cc3885f61..d5ee85de8e Squashed 'buildres/csl/csl-styles/' changes from 3a6a0a7..3bb4b5f Consider directory pattern when checking if a file can be moved (#8244) Bump byte-buddy-parent from 1.12.1 to 1.12.2 (#8285) Bump unirest-java from 3.13.3 to 3.13.4 (#8283) Bump checkstyle from 9.1 to 9.2 (#8284) Bump classgraph from 4.8.135 to 4.8.137 (#8282) Do not resize main table columns in search dialog window (#8253) Fix NegativeArraySizeException (#8270) Update deployment.yml TEst Grand unified library properties (GRULPS) (#8264) Fixes RFC fetcher test case (#8271) Update Gradle Wrapper from 7.2 to 7.3 (#8246) Observable Preferences H (WorkingDir, getUser, NameFormatter, Version, SpecialFields) (#8260) Bump checkstyle from 9.0.1 to 9.1 (#8266) ...
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #8213
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)