Skip to content

Fix CSL update#7592

Merged
koppor merged 9 commits into
mainfrom
fix-csl-update
Mar 30, 2021
Merged

Fix CSL update#7592
koppor merged 9 commits into
mainfrom
fix-csl-update

Conversation

@koppor

@koppor koppor commented Mar 29, 2021

Copy link
Copy Markdown
Member

Follow-up to #7306. I missed committing the update when cp modified a file

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

@koppor

koppor commented Mar 29, 2021

Copy link
Copy Markdown
Member Author

PR is created well. We have to test the auto merge after the update is merged. The solution here did not work: https://github.community/t/do-something-if-a-particular-label-is-set/17149/2?u=koppor, thus I tried that one: https://github.community/t/do-something-if-a-particular-label-is-set/17149/5?u=koppor

@koppor

koppor commented Mar 29, 2021

Copy link
Copy Markdown
Member Author

Squash merge MUST NOT be done at CSL updates - otherwise that does not work any more. I think, the other updates are only one commits large. Thus, I changed the type of the merge to merge

@koppor

koppor commented Mar 30, 2021

Copy link
Copy Markdown
Member Author

This is (more or less) trial and error. Thus, I just merge and we check if it works.

@koppor koppor merged commit cf3a240 into main Mar 30, 2021
@koppor koppor deleted the fix-csl-update branch March 30, 2021 11:46
Siedlerchr added a commit that referenced this pull request Apr 9, 2021
* upstream/main: (25 commits)
  Fix NumberFormatException in BracketedPattern (#7600)
  Update MAINTAINERS (#7601)
  Fix CSL update (#7592)
  Add unit tests for org.jabref.gui classes (#7579)
  Squashed 'buildres/csl/csl-styles/' changes from 30fb68e..e1acabe
  Bump tika-core from 1.25 to 1.26 (#7589)
  Revert "Skip Mac OS build if secret not present (#7591)" (#7594)
  Optimize saving (#7568)
  Skip Mac OS build if secret not present (#7591)
  Rename master to main in dev help
  Update tests-fetchers.yml
  Update refresh-journal-lists.yml
  Update deployment.yml
  Rename master to main in coding readme
  Rename master to main in citation style update
  Rename master to main in gitversion config
  Fix column sort order gets overwritten (#7573)
  Add some hints on test tooling (#7585)
  Add "Update Gradle Wrapper Action" (#7584)
  Bump classgraph from 4.8.102 to 4.8.104 (#7587)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant