Add unit tests for org.jabref.gui classes#7579
Merged
Merged
Conversation
1. AppendPersonNamesStrategyTest 2. PersonNameStringConverterTest 3. ReplaceStringViewModelTest
Siedlerchr
approved these changes
Mar 29, 2021
koppor
approved these changes
Mar 29, 2021
Member
|
Two approvals == mergable. |
Siedlerchr
added a commit
that referenced
this pull request
Apr 9, 2021
* upstream/main: (25 commits) Fix NumberFormatException in BracketedPattern (#7600) Update MAINTAINERS (#7601) Fix CSL update (#7592) Add unit tests for org.jabref.gui classes (#7579) Squashed 'buildres/csl/csl-styles/' changes from 30fb68e..e1acabe Bump tika-core from 1.25 to 1.26 (#7589) Revert "Skip Mac OS build if secret not present (#7591)" (#7594) Optimize saving (#7568) Skip Mac OS build if secret not present (#7591) Rename master to main in dev help Update tests-fetchers.yml Update refresh-journal-lists.yml Update deployment.yml Rename master to main in coding readme Rename master to main in citation style update Rename master to main in gitversion config Fix column sort order gets overwritten (#7573) Add some hints on test tooling (#7585) Add "Update Gradle Wrapper Action" (#7584) Bump classgraph from 4.8.102 to 4.8.104 (#7587) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test coverage for org.jabref.gui package is rather low (8%). This pull request adds unit tests to 3 classes under the gui package, increasing their respective line coverage from 0% to 100%. They contribute to issue #6207.
Tests added:
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)