Add special fields ADR#7300
Merged
Merged
Conversation
Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>
tobiasdiez
approved these changes
Jan 6, 2021
tobiasdiez
left a comment
Member
There was a problem hiding this comment.
Thanks, LGTM!
What was our timeline for the migration? Do we have an open issue for this?
| * Good, because can be easily removed (e.g., by a formatter) | ||
| * Good, because prepares future power of JabRef to make field properties configurable | ||
| * Bad, because bloats BibTeX file (see below) | ||
| * Bad, because requires more timing (see below) |
Member
Author
There was a problem hiding this comment.
Typo --> fixed to "Bad, because requires more writing when editing BibTeX manually by hand"
| ### Special fields as sub-feature of groups | ||
|
|
||
| * Good, because one concept rulez them all | ||
| * Good, because groups already have special handling for author names |
Member
There was a problem hiding this comment.
What is the connection to author names?
Member
Author
Finally, after months after JabCon 😅
The migration itself is (IMHO) the linked issue #6840 with Milestone v5.3 We already have the default to not do any synchronization (released with v5.2). --> #6846 At #JabCon we also noted down following next steps:
We don't have issues for that - should I add some? |
tobiasdiez
approved these changes
Jan 7, 2021
tobiasdiez
left a comment
Member
There was a problem hiding this comment.
Thanks for the explanation!
Siedlerchr
added a commit
that referenced
this pull request
Jan 7, 2021
…dtask * upstream/master: Adjust zbmath fetcher (#7298) Add "acm-siggraph.csl" required by CitationStyle.java Added Keyboard shortcuts (clear/set read status) (#7302) Add special fields ADR (#7300) Overwrite local copies Squashed 'buildres/csl/csl-locales/' content from commit ecb8e70233 Squashed 'buildres/csl/csl-styles/' content from commit 737ffa1 Adapt workflow and build.gradle Move CSL to buildres/csl to speedup "processResources" during development
Siedlerchr
added a commit
that referenced
this pull request
Jan 10, 2021
* upstream/master: (34 commits) Fixed exception about missing custom css file (#7292) Update the templates for opening a new issue (#7321) Entitlements file Mac (#7317) Make CONTRIBUTING.md much shorter. Move long text to docs/contributing.md (#7293) Include Github-optimized screenshot into repository (#7318) Remove obsolete registry patch file (#7316) Fix AUTHORS GitBook: [master] one page modified Remove broken Sonarqube integration (#7315) GitBook: [master] 5 pages and 32 assets modified docs: update license year (#7314) Add javafx version number + update javafx (#7312) Add missing authors Adjust zbmath fetcher (#7298) Add "acm-siggraph.csl" required by CitationStyle.java Added Keyboard shortcuts (clear/set read status) (#7302) Add special fields ADR (#7300) Overwrite local copies Squashed 'buildres/csl/csl-locales/' content from commit ecb8e70233 Squashed 'buildres/csl/csl-styles/' content from commit 737ffa1 ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As input for #6840
This writes down the ADR for special fields discussed at #JabCon.
Result: We have special fields as "normal" BibTeX key/value fields. We do not have synchronization of keywords any more.
Documentation: This will obsolete the last paragraph at https://docs.jabref.org/finding-sorting-and-cleaning-entries/specialfields#configuration-of-the-storage-mode-in-the-library.
For the brave: The ADR can be edited using the UI available at https://github.com/koppor/adr-manager/.