Skip to content

No sync of specialfields to keywords as default#6846

Merged
Siedlerchr merged 6 commits into
masterfrom
refactor-globalprefs-specialfields
Sep 3, 2020
Merged

No sync of specialfields to keywords as default#6846
Siedlerchr merged 6 commits into
masterfrom
refactor-globalprefs-specialfields

Conversation

@calixtus

@calixtus calixtus commented Sep 2, 2020

Copy link
Copy Markdown
Member

fixes #6621

Proof of concept for future refactorings to reduce the calls to JabRefPreferences.get() and .put()

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

@github-actions

github-actions Bot commented Sep 2, 2020

Copy link
Copy Markdown
Contributor

The JabRef maintainers will add the following name to the AUTHORS file. In case you want to use a different one, please comment here and adjust your name in your git configuration for future commits.

chenyuheng

@calixtus calixtus changed the title No sync of specialfields to keywords No sync of specialfields to keywords as default Sep 2, 2020
tobiasdiez
tobiasdiez requested changes Sep 2, 2020
View reviewed changes

@tobiasdiez tobiasdiez left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread src/main/java/org/jabref/gui/JabRefFrame.java Outdated
@koppor koppor added the status: changes-required Pull requests that are not yet complete label Sep 2, 2020
@calixtus calixtus added status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers and removed status: changes-required Pull requests that are not yet complete labels Sep 3, 2020
Siedlerchr
Siedlerchr approved these changes Sep 3, 2020
View reviewed changes
Comment thread CHANGELOG.md Outdated
@Siedlerchr Siedlerchr merged commit 0e5c463 into master Sep 3, 2020
@Siedlerchr Siedlerchr deleted the refactor-globalprefs-specialfields branch September 3, 2020 10:26
Siedlerchr added a commit that referenced this pull request Sep 4, 2020
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into writebackupToTemp
1043d9e 
* upstream/master:
  Fix icon issue (#6858)
  No sync of specialfields to keywords as default (#6846)
  Don't show entry editor on startup (#6861)
  Sort-in root classes into packages (#6853)
  Add "Fetchers" to DevDocs
@calixtus calixtus mentioned this pull request Nov 23, 2020
Closed
@koppor koppor mentioned this pull request Jan 6, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tobiasdiez tobiasdiez tobiasdiez requested changes

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees

No one assigned

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

"Printed" and "Readstatus" are not remembered, when removed from "Keywords"

4 participants

@calixtus @Siedlerchr @tobiasdiez @koppor