Fix Shared Database Tests#7040
Merged
Merged
Conversation
Fix FieldChangeEvent Delta computation
tobiasdiez
requested changes
Oct 26, 2020
* upstream/master: Fix 4040 link Bump java-diff-utils from 4.8 to 4.9 (#7061) Bump bcprov-jdk15on from 1.66 to 1.67 (#7063) Bump checkstyle from 8.36.2 to 8.37 (#7064) Bump mockito-core from 3.5.15 to 3.6.0 (#7067) Bump controlsfx from 11.0.2 to 11.0.3 (#7066) Squashed 'src/main/resources/csl-styles/' changes from 5297abd..5c376b8 add short date formatter (#7039) Add awt native open commands (#7037) Add online-link detection to FileFieldParser (#7043)
rename delta to majorCharacterChange
Siedlerchr
added a commit
to JabRef/jabref-koppor
that referenced
this pull request
Nov 11, 2020
* upstream/master: (164 commits) Bump lucene-queryparser from 8.6.3 to 8.7.0 (JabRef#7089) Fix endnote importer when keyword style is null (JabRef#7084) Rename Firefox extension file in Windows (JabRef#7092) Add support for Microsoft Edge browser in Windows and Linux builds (JabRef#7056) Bump unirest-java from 3.11.03 to 3.11.05 (JabRef#7087) Bump com.github.ben-manes.versions from 0.33.0 to 0.36.0 (JabRef#7088) Bump gittools/actions from v0.9.4 to v0.9.5 (JabRef#7091) Feature/add abstract field to complex search (JabRef#7079) Add missing authors Implement Emacs key bindings (JabRef#6037) Special field code maintenance (JabRef#7078) Follow up fix for 7077 Reset preview layouts on clear Fix preview settings not saved due to l10n (JabRef#7077) Add link to existing documentation of filed types Remove unused supportsPaging Squashed 'src/main/resources/csl-styles/' changes from 5c376b8..f4399aa Fix more 404 links Fix custom theme styles not applied to the entry preview (JabRef#7071) Fix Shared Database Tests (JabRef#7040) Bump byte-buddy-parent from 1.10.17 to 1.10.18 (JabRef#7059) ... # Conflicts: # src/main/java/org/jabref/gui/DefaultInjector.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix FieldChangeEvent Delta computation
The CoarseChangeFilter only reports delta >0 as Major change.
The problem is that when you codewise set new field content with the same exact length as before, but not the same content it still has a delta of 0 and therefore no DB sync is triggered.
A more detailed explanation is #6862 (comment)
Fixes #6862