Add online-link detection to FileFieldParser#7043
Merged
Merged
Conversation
Siedlerchr
approved these changes
Oct 26, 2020
Member
|
Thanks for the contribution! LGTM! |
calixtus
requested changes
Oct 27, 2020
calixtus
left a comment
Member
There was a problem hiding this comment.
Thanks for your work, however, got one important remark.
Contributor
|
Nice contribution! LGTM! |
Siedlerchr
approved these changes
Oct 28, 2020
Siedlerchr
added a commit
that referenced
this pull request
Nov 3, 2020
* upstream/master: Fix 4040 link Bump java-diff-utils from 4.8 to 4.9 (#7061) Bump bcprov-jdk15on from 1.66 to 1.67 (#7063) Bump checkstyle from 8.36.2 to 8.37 (#7064) Bump mockito-core from 3.5.15 to 3.6.0 (#7067) Bump controlsfx from 11.0.2 to 11.0.3 (#7066) Squashed 'src/main/resources/csl-styles/' changes from 5297abd..5c376b8 add short date formatter (#7039) Add awt native open commands (#7037) Add online-link detection to FileFieldParser (#7043)
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7032. The FileFieldParser did not detect an URL and created a LinkedFile object with the URL as a local file path, which caused an error when running "Check integrity".
I'm not sure if the unit test is in the right class.
If this change requires a changelog entry, I'm happy to add one.