Skip to content

Group: "Searching for keywords" searches for a single keyword ==> use singular#6995

Merged
koppor merged 6 commits into
JabRef:masterfrom
mlep:patch-1
Oct 14, 2020
Merged

Group: "Searching for keywords" searches for a single keyword ==> use singular#6995
koppor merged 6 commits into
JabRef:masterfrom
mlep:patch-1

Conversation

@mlep

@mlep mlep commented Oct 9, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

In the Add group window, among the five types of group, there is one called "Searching for keywords".
Since this type of group search for one keyword only, use of singular is more appropriate.

Note: help on groups is outdated. Will work on this later.

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

@koppor

koppor commented Oct 12, 2020

Copy link
Copy Markdown
Member

Still some localization check going wrong... Difficult thing with the localization:

  org.opentest4j.AssertionFailedError: Obsolete keys found in language properties file: 
  Please enter a field name to search for keywords.
  1. CHECK IF THE KEY IS REALLY NOT USED ANYMORE
  2. REMOVE THESE FROM THE ENGLISH LANGUAGE FILE
   ==> expected: <[]> but was: <[Please enter a field name to search for keywords.]>
      at org.jabref.logic.l10n.LocalizationConsistencyTest.findObsoleteLocalizationKeys(LocalizationConsistencyTest.java:126)

  Test findMissingLocalizationKeys() FAILED (1.7s)

  org.opentest4j.AssertionFailedError: DETECTED LANGUAGE KEYS WHICH ARE NOT IN THE ENGLISH LANGUAGE FILE
  PASTE THESE INTO THE ENGLISH LANGUAGE FILE
  
  Please enter a field name to search for a keyword.=Please enter a field name to search for a keyword.
   ==> expected: <[]> but was: <[Please enter a field name to search for a keyword. (src/main/java/org/jabref/gui/groups/GroupDialogViewModel.java LANG)]>
      at org.jabref.logic.l10n.LocalizationConsistencyTest.findMissingLocalizationKeys(LocalizationConsistencyTest.java:114)

@mlep

mlep commented Oct 13, 2020

Copy link
Copy Markdown
Contributor Author

@koppor Thank you for rising this point. I have not been careful enough (I forgot to alter a string in the LN10 EN file). Hopefully, it is ok now. Let's see what the script says...

@koppor koppor merged commit 0563a49 into JabRef:master Oct 14, 2020
Siedlerchr added a commit that referenced this pull request Oct 14, 2020
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into winBuild
99f4de9 
* upstream/master:
  Jstor Fetcher (#6992)
  Group: "Searching for keywords" searches for a single keyword ==> use singular (#6995)
  Merge parsing of bracketed patterns (#6989)
  6848 fixed the issue of clicking collapse all expanding tree (#6993)
  Enable auto sync per default for Open/Libre Office (#6985)
  Bump unirest-java from 3.11.00 to 3.11.01 (#7001)
  Bump byte-buddy-parent from 1.10.16 to 1.10.17 (#7004)
  Bump lucene-queryparser from 8.6.2 to 8.6.3 (#7002)
  Bump postgresql from 42.2.16 to 42.2.17 (#7005)
  Bump pascalgn/automerge-action from v0.11.0 to v0.12.0 (#7006)
  Bump flowless from 0.6.1 to 0.6.2 (#7003)
Siedlerchr added a commit that referenced this pull request Oct 16, 2020
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into checkstyleConfig
489cac4 
* upstream/master:
  Update journalList.mv
  Update to javafx15 (#7018)
  Squashed 'src/main/resources/csl-styles/' changes from 6fab78b..5297abd
  try to fix DEP issue with official jdk (#7008)
  Jstor Fetcher (#6992)
  Group: "Searching for keywords" searches for a single keyword ==> use singular (#6995)
  Merge parsing of bracketed patterns (#6989)
  6848 fixed the issue of clicking collapse all expanding tree (#6993)
  Enable auto sync per default for Open/Libre Office (#6985)
  Bump unirest-java from 3.11.00 to 3.11.01 (#7001)
  Bump byte-buddy-parent from 1.10.16 to 1.10.17 (#7004)
  Bump lucene-queryparser from 8.6.2 to 8.6.3 (#7002)
  Bump postgresql from 42.2.16 to 42.2.17 (#7005)
  Bump pascalgn/automerge-action from v0.11.0 to v0.12.0 (#7006)
  Bump flowless from 0.6.1 to 0.6.2 (#7003)
Siedlerchr added a commit that referenced this pull request Oct 17, 2020
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into writebackupToTemp
7600ea2 
* upstream/master: (58 commits)
  remove any newlines and spaces in isbn when fetching (#7023)
  add exception to error handler in integrity check
  Update journalList.mv
  Update to javafx15 (#7018)
  Squashed 'src/main/resources/csl-styles/' changes from 6fab78b..5297abd
  try to fix DEP issue with official jdk (#7008)
  Jstor Fetcher (#6992)
  Group: "Searching for keywords" searches for a single keyword ==> use singular (#6995)
  Merge parsing of bracketed patterns (#6989)
  6848 fixed the issue of clicking collapse all expanding tree (#6993)
  Enable auto sync per default for Open/Libre Office (#6985)
  Bump unirest-java from 3.11.00 to 3.11.01 (#7001)
  Bump byte-buddy-parent from 1.10.16 to 1.10.17 (#7004)
  Bump lucene-queryparser from 8.6.2 to 8.6.3 (#7002)
  Bump postgresql from 42.2.16 to 42.2.17 (#7005)
  Bump pascalgn/automerge-action from v0.11.0 to v0.12.0 (#7006)
  Bump flowless from 0.6.1 to 0.6.2 (#7003)
  Rewrite guidelines to Java 15 (#6973)
  Lint CHANGELOG.md
  Removing "BibTeX" when not specific to BibTeX (#6983)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mlep @koppor