Jstor Fetcher#6992
Conversation
There was a problem hiding this comment.
Welcome to JabRef! Thanks for your contribution! That's a nice addition. 👍 Overall the code looks good so far, just a few improvements
It would be cool if you could check if it's possible to extend the fetcher so it's a FullTextFetcher and downloads the pdf?
Siedlerchr
left a comment
There was a problem hiding this comment.
LGTM now. Please fix the remaining check style issues.
For external contributes we require that at least two JabRef devs do a code review before it's merged.
|
Thank you for the PR and welcome to the open source world of JabRef. Maybe you already registered for hacktoberfest. This PR will definitively count towards Hacktoberfest and we are looking for more. I will go through your code soon. Meanwhile, may I ask to fix the checktyle issues?
I know that we seem to ignore the red crosses at pull requests, but we are working on getting them green again. Especially "checkstyle" always was taken seriously. |
koppor
left a comment
There was a problem hiding this comment.
Looks good. Some small nitpick comments. Hope, you find time to address them.
|
One more thing - if possible - could you add org.jabref.logic.importer.fetcher.SearchBasedFetcherCapabilityTest? That would help @DominikVoigt to add support for JSTOR for his SLR addition to JabRef. - No need do it in this PR, maybe as follow up PR? #hacktoberfest |
|
I get 403 at a test: I think, it's a permission issue. Thus, I go ahead with merging! Thank you for the quick follow up! |
* upstream/master: Jstor Fetcher (#6992) Group: "Searching for keywords" searches for a single keyword ==> use singular (#6995) Merge parsing of bracketed patterns (#6989) 6848 fixed the issue of clicking collapse all expanding tree (#6993) Enable auto sync per default for Open/Libre Office (#6985) Bump unirest-java from 3.11.00 to 3.11.01 (#7001) Bump byte-buddy-parent from 1.10.16 to 1.10.17 (#7004) Bump lucene-queryparser from 8.6.2 to 8.6.3 (#7002) Bump postgresql from 42.2.16 to 42.2.17 (#7005) Bump pascalgn/automerge-action from v0.11.0 to v0.12.0 (#7006) Bump flowless from 0.6.1 to 0.6.2 (#7003)
* upstream/master: Update journalList.mv Update to javafx15 (#7018) Squashed 'src/main/resources/csl-styles/' changes from 6fab78b..5297abd try to fix DEP issue with official jdk (#7008) Jstor Fetcher (#6992) Group: "Searching for keywords" searches for a single keyword ==> use singular (#6995) Merge parsing of bracketed patterns (#6989) 6848 fixed the issue of clicking collapse all expanding tree (#6993) Enable auto sync per default for Open/Libre Office (#6985) Bump unirest-java from 3.11.00 to 3.11.01 (#7001) Bump byte-buddy-parent from 1.10.16 to 1.10.17 (#7004) Bump lucene-queryparser from 8.6.2 to 8.6.3 (#7002) Bump postgresql from 42.2.16 to 42.2.17 (#7005) Bump pascalgn/automerge-action from v0.11.0 to v0.12.0 (#7006) Bump flowless from 0.6.1 to 0.6.2 (#7003)
* upstream/master: (58 commits) remove any newlines and spaces in isbn when fetching (#7023) add exception to error handler in integrity check Update journalList.mv Update to javafx15 (#7018) Squashed 'src/main/resources/csl-styles/' changes from 6fab78b..5297abd try to fix DEP issue with official jdk (#7008) Jstor Fetcher (#6992) Group: "Searching for keywords" searches for a single keyword ==> use singular (#6995) Merge parsing of bracketed patterns (#6989) 6848 fixed the issue of clicking collapse all expanding tree (#6993) Enable auto sync per default for Open/Libre Office (#6985) Bump unirest-java from 3.11.00 to 3.11.01 (#7001) Bump byte-buddy-parent from 1.10.16 to 1.10.17 (#7004) Bump lucene-queryparser from 8.6.2 to 8.6.3 (#7002) Bump postgresql from 42.2.16 to 42.2.17 (#7005) Bump pascalgn/automerge-action from v0.11.0 to v0.12.0 (#7006) Bump flowless from 0.6.1 to 0.6.2 (#7003) Rewrite guidelines to Java 15 (#6973) Lint CHANGELOG.md Removing "BibTeX" when not specific to BibTeX (#6983) ...
added Fetcher for jstor.org
Fixes #6627