Fix remove actions for entry types in the editor#6933
Merged
Conversation
fixes JabRef#6906 * Created separate view models for standard and custom entry types, adding remove icon only for the custom ones * Updated CHANGELOG.md
Siedlerchr
requested changes
Sep 23, 2020
Siedlerchr
left a comment
Member
There was a problem hiding this comment.
In general looks good to me. Please fix the checkstyle tests.
Co-authored-by: Christoph <cschwentker@gmail.com>
calixtus
reviewed
Sep 23, 2020
calixtus
left a comment
Member
There was a problem hiding this comment.
Great work, just a question about the class StandardEntryTypeViewModel.
|
|
||
| import org.jabref.model.entry.BibEntryType; | ||
|
|
||
| public class StandardEntryTypeViewModel extends EntryTypeViewModel { |
Member
There was a problem hiding this comment.
Is this class really necessary? Wouldn't it be enough to make EntryTypeViewModel not abstract and to extend it to the CustomEntryTypeViewModel?
Contributor
Author
There was a problem hiding this comment.
Yeah, I also though of that. I can change it.
Contributor
Author
|
I've created request with user doc update: JabRef/user-documentation#310 |
Siedlerchr
approved these changes
Sep 23, 2020
Siedlerchr
left a comment
Member
There was a problem hiding this comment.
Thanks, loos good now!
For external contributions we require that at least second dev reviews the changes
calixtus
approved these changes
Sep 23, 2020
Siedlerchr
approved these changes
Sep 24, 2020
Siedlerchr
added a commit
that referenced
this pull request
Sep 26, 2020
…-issue-6707 * upstream/master: (35 commits) Fix a fetcher test for the ShortDOIService (#6945) Fixes Shared Database: Changes filtering in CoarseChangeFilter to attribute property (#6868) Changed default value of "search and store files relative to bibtex file" to true (#6928) Replace comment by just a failure (#6943) Fix: in entry types editor selected field is not removed after first click (#6941) Fix remove actions for entry types in the editor (#6933) Always use Java 15 (#6929) Update DevDocs: workaround for issues with local openjfx maven libraries (#6931) Fixes bugs in the `regex` cite key pattern modifier (#6893) Add missing author Readability for citation key patterns (#6706) Add new author Reset to master and add default case to switch (#6847) Bump mockito-core from 3.5.10 to 3.5.11 (#6924) Bump byte-buddy-parent from 1.10.14 to 1.10.15 (#6923) Bump org.beryx.jlink from 2.21.4 to 2.22.0 (#6925) Bump xmpbox from 2.0.20 to 2.0.21 (#6926) Bump pascalgn/automerge-action from v0.9.0 to v0.10.0 (#6927) Improve parsing of short DOIs (#6920) Bump junit-vintage-engine from 5.6.2 to 5.7.0 (#6910) ...
Siedlerchr
added a commit
that referenced
this pull request
Sep 26, 2020
* upstream/master: (55 commits) Rename menus citation style in preview style (#6899) Fix for some Unicode characters in citation keys (#6938) Add missing authors Fix a fetcher test for the ShortDOIService (#6945) Fixes Shared Database: Changes filtering in CoarseChangeFilter to attribute property (#6868) Changed default value of "search and store files relative to bibtex file" to true (#6928) Replace comment by just a failure (#6943) Fix: in entry types editor selected field is not removed after first click (#6941) Fix remove actions for entry types in the editor (#6933) Always use Java 15 (#6929) Update DevDocs: workaround for issues with local openjfx maven libraries (#6931) Fixes bugs in the `regex` cite key pattern modifier (#6893) Add missing author Readability for citation key patterns (#6706) Add new author Reset to master and add default case to switch (#6847) Bump mockito-core from 3.5.10 to 3.5.11 (#6924) Bump byte-buddy-parent from 1.10.14 to 1.10.15 (#6923) Bump org.beryx.jlink from 2.21.4 to 2.22.0 (#6925) Bump xmpbox from 2.0.20 to 2.0.21 (#6926) ... # Conflicts: # src/main/java/org/jabref/logic/util/DelayTaskThrottler.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #6906
It's working solution, but please take a look whether the implementation is good. I will modify the user doc if it's accepted.