Skip to content

Always use Java 15#6929

Merged
Siedlerchr merged 4 commits into
masterfrom
switch-to-jdk15
Sep 22, 2020
Merged

Always use Java 15#6929
Siedlerchr merged 4 commits into
masterfrom
switch-to-jdk15

Conversation

@koppor

@koppor koppor commented Sep 21, 2020

Copy link
Copy Markdown
Member

Try to build JabRef with JDK15 (which was released 6 days ago - https://openjdk.java.net/projects/jdk/15/

@Siedlerchr

Siedlerchr commented Sep 21, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

If this works then #6829 can be deleted.
We need to test the windows installer and ensure jabref starts.
And rename the step please

tobiasdiez
tobiasdiez reviewed Sep 21, 2020
View reviewed changes
Comment thread .github/workflows/deployment.yml
@koppor

koppor commented Sep 21, 2020

Copy link
Copy Markdown
Member Author

I am not sure, what "works" means. In the PR #6829 no issue or PR or PR comment was linked describing the issue.

I think, it was a Windows issue?!

The build is located at https://builds.jabref.org/pull/6929/merge/.

@koppor

koppor commented Sep 21, 2020

Copy link
Copy Markdown
Member Author

Starts fine on Windows.

@Siedlerchr

Siedlerchr commented Sep 21, 2020

Copy link
Copy Markdown
Member

The standard setup action uses Zulu jdk that created problems because it was not signed and that created the problems hat jabref could not start.
Could be that they also switched to adoptopenjdk variant now again as they did with jdk14

@Siedlerchr Siedlerchr merged commit 129c36e into master Sep 22, 2020
@Siedlerchr Siedlerchr deleted the switch-to-jdk15 branch September 22, 2020 17:22
@Siedlerchr

Siedlerchr commented Sep 22, 2020

Copy link
Copy Markdown
Member

Tested on windows and mac. Both start and mac is signed/notarized correctly

@tobiasdiez

tobiasdiez commented Sep 23, 2020

Copy link
Copy Markdown
Member

Could you please change jdk 14 to 15 everywhere. The local dev environment should be the same as the ci setup.

@Siedlerchr

Siedlerchr commented Sep 23, 2020

Copy link
Copy Markdown
Member

For development we should stick to jdk 14 because tooling/ide support for jdk 15 is (probably) not yet ready on all platforms.
The CI setup is primarily relevant for the jpackage stuff. That's why jdk 15 is used there.
In the end it's just the runtime that is shipped.

Siedlerchr added a commit that referenced this pull request Sep 26, 2020
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into KunAndrew-fix-for…
1102851 
…-issue-6707

* upstream/master: (35 commits)
  Fix a fetcher test for the ShortDOIService (#6945)
  Fixes Shared Database: Changes filtering in CoarseChangeFilter to attribute property (#6868)
  Changed default value of "search and store files relative to bibtex file" to true (#6928)
  Replace comment by just a failure (#6943)
  Fix: in entry types editor selected field is not removed after first click  (#6941)
  Fix remove actions for entry types in the editor (#6933)
  Always use Java 15 (#6929)
  Update DevDocs: workaround for issues with local openjfx maven libraries (#6931)
  Fixes bugs in the `regex` cite key pattern modifier (#6893)
  Add missing author
  Readability for citation key patterns (#6706)
  Add new author
  Reset to master and add default case to switch (#6847)
  Bump mockito-core from 3.5.10 to 3.5.11 (#6924)
  Bump byte-buddy-parent from 1.10.14 to 1.10.15 (#6923)
  Bump org.beryx.jlink from 2.21.4 to 2.22.0 (#6925)
  Bump xmpbox from 2.0.20 to 2.0.21 (#6926)
  Bump pascalgn/automerge-action from v0.9.0 to v0.10.0 (#6927)
  Improve parsing of short DOIs (#6920)
  Bump junit-vintage-engine from 5.6.2 to 5.7.0 (#6910)
  ...
Siedlerchr added a commit that referenced this pull request Sep 26, 2020
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into writebackupToTemp
e2186e7 
* upstream/master: (55 commits)
  Rename menus citation style in preview style (#6899)
  Fix for some Unicode characters in citation keys (#6938)
  Add missing authors
  Fix a fetcher test for the ShortDOIService (#6945)
  Fixes Shared Database: Changes filtering in CoarseChangeFilter to attribute property (#6868)
  Changed default value of "search and store files relative to bibtex file" to true (#6928)
  Replace comment by just a failure (#6943)
  Fix: in entry types editor selected field is not removed after first click  (#6941)
  Fix remove actions for entry types in the editor (#6933)
  Always use Java 15 (#6929)
  Update DevDocs: workaround for issues with local openjfx maven libraries (#6931)
  Fixes bugs in the `regex` cite key pattern modifier (#6893)
  Add missing author
  Readability for citation key patterns (#6706)
  Add new author
  Reset to master and add default case to switch (#6847)
  Bump mockito-core from 3.5.10 to 3.5.11 (#6924)
  Bump byte-buddy-parent from 1.10.14 to 1.10.15 (#6923)
  Bump org.beryx.jlink from 2.21.4 to 2.22.0 (#6925)
  Bump xmpbox from 2.0.20 to 2.0.21 (#6926)
  ...

# Conflicts:
#	src/main/java/org/jabref/logic/util/DelayTaskThrottler.java
@koppor

koppor commented Oct 3, 2020

Copy link
Copy Markdown
Member Author

Using Liberca JDK 15 as of today does not work:

Task :compileJava
Skipped patching fastparse_2.12-1.0.0.jar into test
Skipped patching fastparse-utils_2.12-1.0.0.jar into test2
Skipped patching sourcecode_2.12-0.1.4.jar into test3
C:\git-repositories\jabref\jabref\src\main\java\module-info.java:67: error: module not found: jdk.internal.vm.compiler
    requires jdk.internal.vm.compiler;
                            ^
1 error

> Task :compileJava FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':compileJava'.
> Compilation failed; see the compiler error output for details.

* Try:
Run with --info or --debug option to get more log output. Run with --scan to get full insights.

@Siedlerchr

Siedlerchr commented Oct 3, 2020

Copy link
Copy Markdown
Member

@koppor This looks exactly like the bug I encountered and reported to the AdoptOpenJDK team in the ea build and which got fixed in their variant. It's a problem with the building of client/server versions

adoptium/temurin-build#2047 (comment)

@koppor koppor mentioned this pull request Oct 3, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tobiasdiez tobiasdiez tobiasdiez left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@koppor @Siedlerchr @tobiasdiez