Skip to content

Fix copy pasting and delete via menu or key#6740

Merged
Siedlerchr merged 2 commits into
masterfrom
restoreDelete
Aug 6, 2020
Merged

Fix copy pasting and delete via menu or key#6740
Siedlerchr merged 2 commits into
masterfrom
restoreDelete

Conversation

@Siedlerchr

@Siedlerchr Siedlerchr commented Aug 5, 2020

Copy link
Copy Markdown
Member

Add hack for OSX.
Caveat: Prevents pasting using Cmd+V on an empty library. Menu pasting however works.

Fixes #6739
Fixes #6738
Fixes #6293

Would be nice if someone could test this for windows/linux as well

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

Add hack for OSX.
Caveat: Prevents pasting using Cmd+V on an empty library
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Aug 5, 2020
@Siedlerchr Siedlerchr added this to the v5.1 milestone Aug 5, 2020
@Siedlerchr Siedlerchr changed the title Fix copy pasting via menu Fix copy pasting and delete via menu or key Aug 5, 2020
@Siedlerchr Siedlerchr merged commit 7d66c25 into master Aug 6, 2020
@Siedlerchr Siedlerchr deleted the restoreDelete branch August 6, 2020 15:07
Siedlerchr added a commit that referenced this pull request Aug 9, 2020
* upstream/master: (47 commits)
  Fix copy pasting and delete via menu or key (#6740)
  Add instructions how to work with fetchers  (#6731)
  Autoinstall extension in chrome (#6442)
  Delete link after download (#6723)
  New translations JabRef_en.properties (Portuguese, Brazilian) (#6728)
  Bump pascalgn/automerge-action from v0.8.5 to v0.9.0 (#6736)
  Bump byte-buddy-parent from 1.10.13 to 1.10.14 (#6733)
  Bump mockito-core from 3.4.4 to 3.4.6 (#6734)
  Bump unirest-java from 3.8.06 to 3.9.00 (#6735)
  Bump org.beryx.jlink from 2.21.1 to 2.21.2 (#6732)
  Add testing interface, including a set of capabilities to tests for (#6687)
  Fix pasting on mac and linux (#6419)
  Add validation of "AUTHORS" file (#6722)
  Squashed 'src/main/resources/csl-styles/' changes from cacc4ee..827b986
  New Crowdin updates (#6721)
  Add missing AUTHORs
  Fix for issue 6639 (#6719)
  Fix more links
  Fix link
  New Crowdin updates (#6718)
  ...
@ytzemih

ytzemih commented Aug 27, 2020

Copy link
Copy Markdown

This bug reoccurs for me on
JabRef 5.1--2020-08-22--dc55a76
Linux 5.4.19-050419-generic amd64
Java 14.0.2

I can't help but now, under Linux, neither the cut/copy, nor paste buttons seem to work anymore, consistently. I'm using, as you can see, a JabRef just a couple of days old. However, using keyboard shortcuts works as usual.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

unable to delete an entry Delete and Cut functionalities do not work anymore Paste button on maintable does not work properly

2 participants