Add validation of "AUTHORS" file#6722
Merged
Merged
Conversation
tobiasdiez
requested changes
Jul 28, 2020
tobiasdiez
left a comment
Member
There was a problem hiding this comment.
LGTM, just a bit of nit-picking.
| echo "No authors added" | ||
| exit 0 | ||
| fi | ||
| message="When merged, this pull request will introduce additions in the [AUTHORS file](https://github.com/JabRef/jabref/blob/master/CONTRIBUTING.md#author-credits). In case you want to appear differently, please [adjust your name in your git configuration](https://docs.github.com/en/github/using-git/setting-your-username-in-git).%0A%0A\`\`\`%0A${added//$'\n'/'%0A'}%0A\`\`\`%0A" |
Member
There was a problem hiding this comment.
And then force push? or how is the change to the git config reflected in the PR?
Member
Author
There was a problem hiding this comment.
Yes. Could be difficult for the newcomers. Nevertheless, I would urge them to get their git configured properly.
I added some text with links here.
Siedlerchr
added a commit
that referenced
this pull request
Aug 9, 2020
* upstream/master: (47 commits) Fix copy pasting and delete via menu or key (#6740) Add instructions how to work with fetchers (#6731) Autoinstall extension in chrome (#6442) Delete link after download (#6723) New translations JabRef_en.properties (Portuguese, Brazilian) (#6728) Bump pascalgn/automerge-action from v0.8.5 to v0.9.0 (#6736) Bump byte-buddy-parent from 1.10.13 to 1.10.14 (#6733) Bump mockito-core from 3.4.4 to 3.4.6 (#6734) Bump unirest-java from 3.8.06 to 3.9.00 (#6735) Bump org.beryx.jlink from 2.21.1 to 2.21.2 (#6732) Add testing interface, including a set of capabilities to tests for (#6687) Fix pasting on mac and linux (#6419) Add validation of "AUTHORS" file (#6722) Squashed 'src/main/resources/csl-styles/' changes from cacc4ee..827b986 New Crowdin updates (#6721) Add missing AUTHORs Fix for issue 6639 (#6719) Fix more links Fix link New Crowdin updates (#6718) ...
5 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just before a release, I have to check the names of the contributors to be able to add them to
AUHTORS. This is a good habit, where I received positive feedback for. We outline that in our contribution guide at https://github.com/JabRef/jabref/blob/master/CONTRIBUTING.md#author-credits, but it seems no one reads that far.The issue is that 80% of the names are wrong. Be it casing errors, misspellings, multiple email adresses with slightly dfferent name, or no name at all.
To redeuce the load on my side, I created a check which comments on the PR if some new names will be added.
Example:
The check renders as follows if no new AUTHOR was found: