Skip to content

Readd file associations#5625

Merged
tobiasdiez merged 4 commits into
masterfrom
addFileAssoc
Nov 19, 2019
Merged

Readd file associations#5625
tobiasdiez merged 4 commits into
masterfrom
addFileAssoc

Conversation

@tobiasdiez

@tobiasdiez tobiasdiez commented Nov 17, 2019

Copy link
Copy Markdown
Member

Fixes #5520. At least works on Windows. @LyzardKing could you please test this for linux as well? Thanks!

@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Nov 17, 2019
@koppor koppor requested a review from LyzardKing November 17, 2019 20:14
@LyzardKing

LyzardKing commented Nov 17, 2019

Copy link
Copy Markdown
Collaborator

I'll test it and see if the mimetype line can be removed from the .desktop template

@LyzardKing

LyzardKing commented Nov 17, 2019

Copy link
Copy Markdown
Collaborator

@tobiasdiez It works, in adding the association.
The problem is that jpackage isn't using the altered .desktop template in the buildres folder,
and that (I think) is also the reason for the issue with the browser addon opening new instances...
We'ew not adding the following:

GenericName=BibTeX Editor
Keywords=bibtex;biblatex;latex;bibliography
StartupWMClass=org-jabref-JabRefMain

@LyzardKing

LyzardKing commented Nov 17, 2019

Copy link
Copy Markdown
Collaborator

I think I found out how to fix the issue.
If you want to add the change to this PR the diff is minimal:

  • rename buildres/linux/jabref-JabRef.desktop to buildres/linux/JabRef.desktop
  • in that file replace the MimeType line with DESKTOP_MIMES

LyzardKing
LyzardKing reviewed Nov 17, 2019
View reviewed changes

@LyzardKing LyzardKing left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's only a small change to the linux desktop file.
It does seem to work, although in Ubuntu Mate I don't see the icon on the .bib files, but the association works..

@koppor @LyzardKing
Fix mime types of JabRef on Linux
1f607e5 
Co-authored-by: Galileo Sartor <galileo.sartor@gmail.com>
@koppor

koppor commented Nov 18, 2019

Copy link
Copy Markdown
Member

@LyzardKing I hope, I understood your comment correctly: 1f607e5

@tobiasdiez

tobiasdiez commented Nov 18, 2019

Copy link
Copy Markdown
Member Author

Maybe the icon name in the association file is wrong. Do you have a png file next to the executable in the installed directory?

@LyzardKing

LyzardKing commented Nov 19, 2019 •
edited
Loading

Copy link
Copy Markdown
Collaborator

@koppor Yes, that's the same thing I tested..
I'll have a look at the deb on master.
Actually no..there's an error..

LyzardKing
LyzardKing requested changes Nov 19, 2019
View reviewed changes
Comment thread buildres/linux/JabRef.desktop Outdated
@LyzardKing

LyzardKing commented Nov 19, 2019

Copy link
Copy Markdown
Collaborator

@tobiasdiez in jabref/lib there's the icon, and it's JabRef.png
But it doesn't seem to work with that either..

tobiasdiez and others added 2 commits November 19, 2019 12:35
@tobiasdiez @LyzardKing
Update buildres/linux/JabRef.desktop
3511828 
Co-Authored-By: Galileo Sartor <galileo.sartor@gmail.com>
@tobiasdiez
Update bibtexAssociations.properties
856397a
@tobiasdiez tobiasdiez merged commit 80154a4 into master Nov 19, 2019
@tobiasdiez tobiasdiez deleted the addFileAssoc branch November 19, 2019 11:50
koppor pushed a commit that referenced this pull request Sep 15, 2021
Squashed 'buildres/csl/csl-styles/' changes from 2b37392..5facb37
4484d25 
5facb37 Update soil-biology-and-biochemistry.csl (#5630)
dba7c17 Change representation of locators (#5629)
38c5b99 change et-al settings (#5628)
634b5e0 Create netherlands-journal-of-geosciences.csl (#5624)
fa2cce2 Create journal-of-information-literacy.csl (#5622)
c0d2bf1 Add legislation to AZR & Austrian Legal (#5625)
9724c6e UACJ: Fix op. cit.
b12f90f Update style-manual-australian-government.csl (#5603)
94dba2c Create sports-health.csl (#5620)
2ca5cd8 Update urad-rs-za-makroekonomske-analize-in-razvoj.csl (#5619)
32ef9ba Create annals-of-eye-science.csl (#5615)
928e5a6 Create journal-of-microbiology.csl (#5616)
a829c84 Update harvard-cite-them-right-no-et-al.csl (#5617)
6182c7b Fix the right _St. York_ Harvard style
1454760 Fix York Harvard title
d8c5cef Create harvard-cite-them-right-11.csl (#5612)

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: 5facb37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LyzardKing LyzardKing LyzardKing requested changes

Assignees

No one assigned

Labels

platform: linux status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add file associations when installing

3 participants

@tobiasdiez @LyzardKing @koppor