Move to extended enums for fields and entry types#5148
Merged
Conversation
Siedlerchr
reviewed
Jul 23, 2019
Member
Author
|
So this is finally ready for review. For some reason the Docbook5 test fails on travis but works for me locally. Could someone else please test this? |
Siedlerchr
reviewed
Jul 25, 2019
Siedlerchr
reviewed
Jul 25, 2019
LinusDietz
approved these changes
Aug 1, 2019
LinusDietz
left a comment
Member
There was a problem hiding this comment.
Well... properly reviewing this PR will be quite impossible. I have skimmed the most important files and tested JabRef manually.
LGTM!
Member
|
Regarding I could not check this before 😅 |
Siedlerchr
added a commit
that referenced
this pull request
Aug 9, 2019
…rter # By David Méndez (47) and others # Via GitHub (5) and David Méndez (3) * upstream/master: (57 commits) fix wrong package (#5181) Remove logging message for non-existing nested files Bump applicationinsights-core from 2.4.0 to 2.4.1 (#5171) Bump archunit-junit5-engine from 0.10.2 to 0.11.0 (#5157) Bump applicationinsights-logging-log4j2 from 2.4.0 to 2.4.1 (#5172) Bump tika-core from 1.21 to 1.22 (#5166) Fix fail on testPerformExportForSingleEntry from DocBook5ExporterTest (#5168) Add a check for nested files and improve the code to skip lines (DefaultTexParser) Add latest changes to latexintegration (#5170) LaTeX integration latest changes (#5167) Move to extended enums for fields and entry types (#5148) Bump archunit-junit5-api from 0.10.2 to 0.11.0 (#5158) Revert temporal change Fix all issues from reviews of #5137 Bump com.simonharrer.modernizer from 1.6.0-1 to 1.8.0-1 (#5154) Bump checkstyle from 8.22 to 8.23 (#5153) Add a new JabRefIcons.LATEX_CITATIONS Change toString() methods Update DefaultTexParser for explaining when and why it skips the citation matching Update TexParserResult for avoiding 'orElse(null)' ... # Conflicts: # src/main/java/org/jabref/logic/importer/fileformat/PdfContentImporter.java # src/test/java/org/jabref/logic/importer/fileformat/PdfContentImporterTest.java
Siedlerchr
added a commit
that referenced
this pull request
Aug 10, 2019
…ator because natural order will require same types of the enum Followup from #5148
6 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a huge refactor PR. I'm sorry for its size, but I couldn't break it down into smaller pieces. The changes are as follows:
Fieldfor fields (e.gStandardField.AUTHORinstead of the string "author") and use this everywhere. Besides the name of the field, some basic and universal properties are stored (e.g. whether it is a numeric field)BibFieldwhich enriches theFieldby properties that depend on the entry (type) where this field is used. Right now this is only how important the field is (which should in the long term replace the required/optional dichometry.EntryTypefor entry types (e.g.StandardEntryType.ARTICLEinstead of the string "article") and use this everywhere.BibEntryTypethat enriches anEntryTypeby properties that the user can configure (e.g. required fields).I tried to not change any behavior, except the following things that I noticed while testing:
pubstatusinstead of the standard BibTeX fieldpubstate.