Skip to content

Fix enum class cast error in TreeSet by specifying an explicit comparator#5184

Merged
Siedlerchr merged 1 commit into
masterfrom
fixEnumErrorClassCAst
Aug 13, 2019
Merged

Fix enum class cast error in TreeSet by specifying an explicit comparator#5184
Siedlerchr merged 1 commit into
masterfrom
fixEnumErrorClassCAst

Conversation

@Siedlerchr

Copy link
Copy Markdown
Member

because natural order will require same types of the enum

Followup from #5148


  • Change in CHANGELOG.md described
  • Tests created for changes
  • Manually tested changed features in running JabRef
  • Screenshots added in PR description (for bigger UI changes)
  • Ensured that the git commit message is a good one
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

…ator

because natural order will require same types of the enum

Followup from  #5148
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Aug 10, 2019
@Siedlerchr Siedlerchr changed the title Fix enum class cast in TreeSet error by specifying an explicit comparator Fix enum class cast error in TreeSet by specifying an explicit comparator Aug 10, 2019

@davidemdot davidemdot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Siedlerchr Siedlerchr merged commit 0255dda into master Aug 13, 2019
@Siedlerchr Siedlerchr deleted the fixEnumErrorClassCAst branch August 13, 2019 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants