Ui preferences global modifications#4926
Merged
Merged
Conversation
Convert dialog for importing custom entry types to CheckListView Rework threading when opening a database
simplify code
fix l10n Remove obsolete code
* Toggle enable status of menu items (prototype) * Use for pushtoapplication * Improve code around push to applications * Set enable status for all actions * Fix tests and checkstyle
…ences Use ObservableList instead of LIstProperty
* Fix for the issue #4912 Apostrophe character removed from KEY_ILLEGAL_CHARACTERS in BibtexKeyGenerator * Add special character to KEY_ILLEGAL_CHARACTERS ʹ added to KEY_ILLEGAL_CHARACTERS and an assertion has been added in testMakeLabelAndCheckLegalKeysAccentGrave
tobiasdiez
approved these changes
Apr 27, 2019
tobiasdiez
left a comment
Member
There was a problem hiding this comment.
Thanks a lot for your PR. It looks indeed way better now!
Siedlerchr
reviewed
Apr 27, 2019
Siedlerchr
left a comment
Member
There was a problem hiding this comment.
Thanks! I noticed that the entry preview tab, there left list view could also be improved. It takes so much width that the right side is not visible or only after scrolling.
Would you mind fixing that as well?
Author
|
Ok I'll see, but what about the codecov/project? Why does the test fail ? |
Member
|
You can ignore that codecov test, it's about how much of the code is covered by tests. But for GUI this is not relevant. The model and logic classes are more important and they are mostly covered. |
Member
|
I'll merge this now. Feel more than welcome to create a new PR for further improvements! |
Siedlerchr
added a commit
that referenced
this pull request
Apr 30, 2019
* upstream/master: (29 commits) Improve author parsing (#4931) Ui preferences global modifications (#4926) Bump checkstyle from 8.19 to 8.20 (#4928) Bump mysql-connector-java from 8.0.15 to 8.0.16 (#4924) UI Preferences->advanced tab optimization : separators and text modification (#4922) Fix for the issue #4912 (#4916) Refactorings, move functionality of CustomEntryTypesManager to Preferences Use ObservableList instead of LIstProperty Toggle enable status of menu items (#4872) Fixes throwing an exception when 'id' field is present in bib file (#4918) Quick fix for error when opening preferences (#4917) Revert "Create new layout for preferences regarding columns" Create new layout for preferences regarding columns Rearrange the padding of the "Append library" dialog (#4914) Make Group dialog resizable (#4910) Adjust save exception to inlcude orgininal stack traces remove dialogService parameter remove dialog service argument rework dialog, create fxml etc fix l10n Remove obsolete code rework threading stuff simplify code Fix Some Codacy Code Convention Issues (#4904) ... # Conflicts: # src/main/java/org/jabref/gui/JabRefFrame.java # src/main/java/org/jabref/gui/customentrytypes/FieldSetComponent.java
Siedlerchr
added a commit
that referenced
this pull request
May 1, 2019
* upstream/master: Throw BibEntryNotFound exception in case entry is no longer present (#4935) Improve author parsing (#4931) Ui preferences global modifications (#4926) Bump checkstyle from 8.19 to 8.20 (#4928) Bump mysql-connector-java from 8.0.15 to 8.0.16 (#4924) UI Preferences->advanced tab optimization : separators and text modification (#4922) # Conflicts: # src/main/java/org/jabref/gui/search/SearchWorker.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UI improvements in Preferences tab : General, File, Network, Groups and EntryEditors.
I did some minors adjustments, deleted useless rows, used HBox in the GridPane, moved some separators.
examples :
Preferences -> General Tab BEFORE :
Preferences -> General Tab AFTER :
Preferences -> Network Tab BEFORE :
Preferences -> Network Tab AFTER :