Rearrange the padding of the "Append library" dialog#4914
Merged
tobiasdiez merged 1 commit intoApr 23, 2019
Conversation
I have added a 5 pixels padding on the left of the container. Also removed a duplicate line related to the padding.
Siedlerchr
approved these changes
Apr 23, 2019
Siedlerchr
left a comment
Member
There was a problem hiding this comment.
Thanks for the contribution!
Siedlerchr
added a commit
that referenced
this pull request
Apr 24, 2019
* upstream/master: Toggle enable status of menu items (#4872) Fixes throwing an exception when 'id' field is present in bib file (#4918) Quick fix for error when opening preferences (#4917) Revert "Create new layout for preferences regarding columns" Create new layout for preferences regarding columns Rearrange the padding of the "Append library" dialog (#4914) Make Group dialog resizable (#4910) Adjust save exception to inlcude orgininal stack traces
Siedlerchr
added a commit
that referenced
this pull request
Apr 24, 2019
* upstream/master: Fix for the issue #4912 (#4916) Refactorings, move functionality of CustomEntryTypesManager to Preferences Use ObservableList instead of LIstProperty Toggle enable status of menu items (#4872) Fixes throwing an exception when 'id' field is present in bib file (#4918) Quick fix for error when opening preferences (#4917) Revert "Create new layout for preferences regarding columns" Create new layout for preferences regarding columns Rearrange the padding of the "Append library" dialog (#4914) Make Group dialog resizable (#4910) Adjust save exception to inlcude orgininal stack traces remove dialogService parameter remove dialog service argument rework dialog, create fxml etc fix l10n Remove obsolete code rework threading stuff simplify code Rework PosteOpenActions to javafx (custom entry type import) Rework PosteOpenActions to javafx (custom entry type import)
Siedlerchr
added a commit
that referenced
this pull request
Apr 30, 2019
* upstream/master: (29 commits) Improve author parsing (#4931) Ui preferences global modifications (#4926) Bump checkstyle from 8.19 to 8.20 (#4928) Bump mysql-connector-java from 8.0.15 to 8.0.16 (#4924) UI Preferences->advanced tab optimization : separators and text modification (#4922) Fix for the issue #4912 (#4916) Refactorings, move functionality of CustomEntryTypesManager to Preferences Use ObservableList instead of LIstProperty Toggle enable status of menu items (#4872) Fixes throwing an exception when 'id' field is present in bib file (#4918) Quick fix for error when opening preferences (#4917) Revert "Create new layout for preferences regarding columns" Create new layout for preferences regarding columns Rearrange the padding of the "Append library" dialog (#4914) Make Group dialog resizable (#4910) Adjust save exception to inlcude orgininal stack traces remove dialogService parameter remove dialog service argument rework dialog, create fxml etc fix l10n Remove obsolete code rework threading stuff simplify code Fix Some Codacy Code Convention Issues (#4904) ... # Conflicts: # src/main/java/org/jabref/gui/JabRefFrame.java # src/main/java/org/jabref/gui/customentrytypes/FieldSetComponent.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added a 5 pixels padding on the left of the container in AppendDatabaseDialog.
Also removed a duplicate line related to the padding.