Enhanced message log by r0light · Pull Request #4815 · JabRef/jabref

r0light · 2019-03-27T14:54:52Z

Worked on #4805 .
Removed JabRefFrame.output in favor of FXDialogService.notify and refactored calling code.
Added Logging to FXDialogService.notify

Logs seemed to be duplicated afterwards. However, this was another issue with log4j. Because LogEvent-Objects are reused, they were copied in LogMessages.add . But at that point it was too late, resulting in different Log Messages being overwritten. I therefore moved the copying to GuiAppender.append and this resolves the issue of seemingly duplicated log messages.
This is probably also the reason for #4811

closes #4805 closes #4811

Change in CHANGELOG.md described
Tests created for changes
Manually tested changed features in running JabRef
Screenshots added in PR description (for bigger UI changes)
Ensured that the git commit message is a good one
Check documentation status (Issue created for outdated help page at help.jabref.org?)

…FXDialogService.notify

…fGUI

Siedlerchr · 2019-03-27T15:00:50Z

                    + pr.getErrorMessage();

-            dialogService.showErrorDialogAndWait(Localization.lang("Error opening file"), message);
+            JabRefGUI.mainFrame.getDialogService().showErrorDialogAndWait(Localization.lang("Error opening file"), message);


This change doesn't make any sense. You are already in JabRef Gui and already have a DialogService object

True, reversed this in commit 7e20650.

Siedlerchr · 2019-03-27T15:01:58Z


    public void output(String s) {
-        frame.output(s);
+        frame.getDialogService().notify(s);


I'm pretty sure BasePanel also has already the dialogServie object

You're right, did not see the attribute at first. Done in 23362fa

tobiasdiez

Thanks for your PR. I've only two minor suggestions, then we can merge.

tobiasdiez · 2019-03-28T17:51:04Z

    @Deprecated
    public FXDialogService() {
-        this(null);
+        this(null, null);


The null argument will lead to a NPE below in notify. Leaving it as this(null) should work.

Ok, I will fix it in the next commit.

tobiasdiez · 2019-03-28T17:52:19Z

    public void notify(String message) {
-        JabRefGUI.getMainFrame().output(message);
+        LOGGER.info(message);
+        DefaultTaskExecutor.runInJavaFXThread(() -> statusLine.fireEvent(new SnackbarEvent(new JFXSnackbarLayout(message), TOAST_MESSAGE_DISPLAY_TIME, null)));


Please remove the runInJavaFXThread. This is a leftover when we had a lot of interaction between Swing and JavaFX code.

I think this method is still sometimes called from background threads therefore we risk exceptions

Is there an alternative to this method? I also think it is necessary to run it on the JavaFX thread, for example in SendAsEmailAction.action notify is called from a background thread.

Usually background tasks are not allowed to communicate things directly. The general principle is that only the hard work is moved to a different task (by using BackgroundTask.wrap(doHardWork)) and the only user interaction should be in the onSuccess and onError handlers that automatically run on the JavaFX thread).

Personally, I would prefer exceptions instead of facing potentially hard to debug threading issues. But for now you can simply leave the runInJavaFXThread call.

Ok, I understand and will keep that in mind.

…nhancedMessageLog

…kExecutor.runInJavaFXThread

Siedlerchr · 2019-04-02T14:16:21Z

                                                  Localization.lang("Open console") + " - " + Localization.lang("Error"),
                                                  JOptionPane.ERROR_MESSAGE);
-                    JabRefGUI.getMainFrame().getDialogService().notify(null);
                }


I just saw that we seemed to forgot to convert that old swing dialog here. Could you please fix this as well?
dialogService.showErrorDialog or so should work
Thanks!

did it in f2a31d0, there was also another one in the same class

Siedlerchr · 2019-04-02T14:19:03Z

+            for (Path file : filesToOpen) {
+                // Run the actual open in a thread to prevent the program locking until the file is loaded.
+                BackgroundTask.wrap(() -> openIt(file, dialog.importEntries(), dialog.importStrings(), dialog.importGroups(), dialog.importSelectorWords()))
+                              .onSuccess(fileName -> { dialogService.notify(Localization.lang("Imported from library") + " '" + fileName + "'");})


singleLineLambdas usually don't need curly braces

fixed it :)

r0light · 2019-04-02T20:19:14Z

-                            Integer.toString(count), totalCount, Integer.toString(foundCount)));
+                    final String nextStatusMessage = Localization.lang("Looking up %0... - entry %1 out of %2 - found %3",
+                            fetcher.getIdentifierName(), Integer.toString(count), totalCount, Integer.toString(foundCount));
+                    DefaultTaskExecutor.runInJavaFXThread(() -> frame.getDialogService().notify(nextStatusMessage));


lookupIdentifiers is executed in a background thread and in order to provide feedback to the user, i used a workaround here and explicitly called DefaultTaskExecutor.runInJavaFXThread
However, i would suggest to completely remove the notifications here, because they do not provide much value

r0light · 2019-04-02T20:23:05Z

                    imports.add(Globals.IMPORT_FORMAT_READER.importUnknownFormat(filename, Globals.getFileUpdateMonitor()));
                } else {
-                    frame.output(Localization.lang("Importing in %0 format", importer.get().getName()) + "...");
+                    DefaultTaskExecutor.runInJavaFXThread(() -> frame.getDialogService().notify(Localization.lang("Importing in %0 format", importer.get().getName()) + "..."));


Also a workaround here and i would suggest to remove the notifications

r0light · 2019-04-02T20:30:18Z

@Siedlerchr @tobiasdiez
I thought while i'm at this anyway, i could also do it properly and checked all calls to DialogService.notify. I refactored all places where the method was called from a background thread, so that i could remove DefaultTaskExecutor.runInJavaFXThread from DialogService.notify.
At two points however it was not as easy, see the review above.
What do you think?

tobiasdiez · 2019-04-02T20:42:45Z

Thanks for the update. The BackgroundTask has updateProgress and updateMessage for these cases. However, an implementation along these lines needs further refactoring I guess. In my opinion, we can leave it like that for the moment and merge.

r0light · 2019-04-03T09:16:36Z

Ok, so maybe a follow-up issue could then be to improve the Identifier lookup and maybe also the fulltext lookup using updateProgress and updateMessage ?
This is ready for merge then, i guess.

Siedlerchr · 2019-04-03T09:18:58Z

Yes, to change the identifer lookkup and the other would be a good followup issue

2f0d735 Improve localization of DGfP 683d7d1 Create zeitschrift-fur-theologie-und-philosophie.csl (JabRef#4813) 7c82406 always show DOI in aps.csl (JabRef#4820) 1eb531d Update journal-of-international-business-studies.csl (JabRef#4819) 9caf926 Create interdisziplinare-anthropologie.csl (JabRef#4818) 00210e1 UKSW2 (JabRef#4807) 015db6e UKSW1 (JabRef#4800) f706ef5 Update masarykova-univerzita-pravnicka-fakulta.csl (JabRef#4822) 096108d Update epilepsia.csl (JabRef#4823) 07ebdc3 Update eksploatacja-i-niezawodnosc.csl (JabRef#4824) 3d50f3c Create ABNT-Universidade-Federal-de-Pernambuco-CFCH.csl (JabRef#4798) df94fa1 Update eksploatacja-i-niezawodnosc.csl (JabRef#4808) 4089be5 Update bulletin-de-la-societe-prehistorique-francaise.csl (JabRef#4810) f130aa7 Update molecular-biology-and-evolution.csl (JabRef#4814) 86f452f Create heiliger-dienst.csl (JabRef#4815) 5ccd3e9 Update revista-brasileira-de-ciencia-do-solo.csl (JabRef#4817) 0eea734 Fix a delimiter in journal-of-the-royal-society-of-western-australia.csl (JabRef#4811) 1cbe790 Delete heiliger-dienst.csl 19fa29f Create heiliger-dienst.csl (JabRef#4787) 888bad1 Update RMIT Harvard to match Easy Cite (JabRef#4788) 46011dd Create universite-nangui-abrogoua-ufr-sn (JabRef#4676) 174adab Create apa-6th-edition-no-ampersand.csl (JabRef#4767) 03cf65f Create journal-of-plant-protection-research.csl (JabRef#4797) c749084 Update eksploatacja-i-niezawodnosc.csl (JabRef#4782) 17e1501 Update masarykova-univerzita-pravnicka-fakulta.csl (JabRef#4783) 5596d18 Update revista-brasileira-de-ciencia-do-solo.csl (JabRef#4790) 9c1a381 create csl for the journal Textual Cultures (JabRef#4785) 8345762 Update taylor-and-francis-national-library-of-medicine.csl (JabRef#4786) 5ec1acf Create british-journal-of-criminology.csl (JabRef#4789) 68550ac Update angewandte-chemie.csl (JabRef#4791) 09e2755 Create shock.csl (JabRef#4792) d46e49e Update antioxidants-and-redox-signaling.csl (JabRef#4793) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 2f0d735

70beb7b Harvard Lancaster: Fix in-text locator 0709b73 Update informal-logic.csl (JabRef#4831) d18d133 Update gost-r-7-0-5-2008.csl (JabRef#4829) cfb5389 Update gost-r-7-0-5-2008-numeric.csl (JabRef#4828) 0fc46ea Update gost-r-7-0-5-2008-numeric-alphabetical.csl (JabRef#4827) fac26cb Create feminist-theory.csl (JabRef#4830) a2721e6 Update pravnik.csl, masarykova-univerzita-pravnicka-fakulta.csl, and iso690-full-note-cs.csl (JabRef#4826) 2f0d735 Improve localization of DGfP 683d7d1 Create zeitschrift-fur-theologie-und-philosophie.csl (JabRef#4813) 7c82406 always show DOI in aps.csl (JabRef#4820) 1eb531d Update journal-of-international-business-studies.csl (JabRef#4819) 9caf926 Create interdisziplinare-anthropologie.csl (JabRef#4818) 00210e1 UKSW2 (JabRef#4807) 015db6e UKSW1 (JabRef#4800) f706ef5 Update masarykova-univerzita-pravnicka-fakulta.csl (JabRef#4822) 096108d Update epilepsia.csl (JabRef#4823) 07ebdc3 Update eksploatacja-i-niezawodnosc.csl (JabRef#4824) 3d50f3c Create ABNT-Universidade-Federal-de-Pernambuco-CFCH.csl (JabRef#4798) df94fa1 Update eksploatacja-i-niezawodnosc.csl (JabRef#4808) 4089be5 Update bulletin-de-la-societe-prehistorique-francaise.csl (JabRef#4810) f130aa7 Update molecular-biology-and-evolution.csl (JabRef#4814) 86f452f Create heiliger-dienst.csl (JabRef#4815) 5ccd3e9 Update revista-brasileira-de-ciencia-do-solo.csl (JabRef#4817) 0eea734 Fix a delimiter in journal-of-the-royal-society-of-western-australia.csl (JabRef#4811) 1cbe790 Delete heiliger-dienst.csl 19fa29f Create heiliger-dienst.csl (JabRef#4787) 888bad1 Update RMIT Harvard to match Easy Cite (JabRef#4788) 46011dd Create universite-nangui-abrogoua-ufr-sn (JabRef#4676) 174adab Create apa-6th-edition-no-ampersand.csl (JabRef#4767) 03cf65f Create journal-of-plant-protection-research.csl (JabRef#4797) c749084 Update eksploatacja-i-niezawodnosc.csl (JabRef#4782) 17e1501 Update masarykova-univerzita-pravnicka-fakulta.csl (JabRef#4783) 5596d18 Update revista-brasileira-de-ciencia-do-solo.csl (JabRef#4790) 9c1a381 create csl for the journal Textual Cultures (JabRef#4785) 8345762 Update taylor-and-francis-national-library-of-medicine.csl (JabRef#4786) 5ec1acf Create british-journal-of-criminology.csl (JabRef#4789) 68550ac Update angewandte-chemie.csl (JabRef#4791) 09e2755 Create shock.csl (JabRef#4792) d46e49e Update antioxidants-and-redox-signaling.csl (JabRef#4793) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 70beb7b

c5f14e2 Update journal-of-plant-ecology.csl (JabRef#4837) b5d00ab Hotfix: pravnik.csl & iso690-full-note-cs.csl (JabRef#4833) fb8d48a add PMID and DOI (JabRef#4832) 7ebdfff Update lancaster-university-harvard.csl (JabRef#4836) 8771e21 Create journal-of-clinical-neurology.csl (JabRef#4835) 70beb7b Harvard Lancaster: Fix in-text locator 0709b73 Update informal-logic.csl (JabRef#4831) d18d133 Update gost-r-7-0-5-2008.csl (JabRef#4829) cfb5389 Update gost-r-7-0-5-2008-numeric.csl (JabRef#4828) 0fc46ea Update gost-r-7-0-5-2008-numeric-alphabetical.csl (JabRef#4827) fac26cb Create feminist-theory.csl (JabRef#4830) a2721e6 Update pravnik.csl, masarykova-univerzita-pravnicka-fakulta.csl, and iso690-full-note-cs.csl (JabRef#4826) 2f0d735 Improve localization of DGfP 683d7d1 Create zeitschrift-fur-theologie-und-philosophie.csl (JabRef#4813) 7c82406 always show DOI in aps.csl (JabRef#4820) 1eb531d Update journal-of-international-business-studies.csl (JabRef#4819) 9caf926 Create interdisziplinare-anthropologie.csl (JabRef#4818) 00210e1 UKSW2 (JabRef#4807) 015db6e UKSW1 (JabRef#4800) f706ef5 Update masarykova-univerzita-pravnicka-fakulta.csl (JabRef#4822) 096108d Update epilepsia.csl (JabRef#4823) 07ebdc3 Update eksploatacja-i-niezawodnosc.csl (JabRef#4824) 3d50f3c Create ABNT-Universidade-Federal-de-Pernambuco-CFCH.csl (JabRef#4798) df94fa1 Update eksploatacja-i-niezawodnosc.csl (JabRef#4808) 4089be5 Update bulletin-de-la-societe-prehistorique-francaise.csl (JabRef#4810) f130aa7 Update molecular-biology-and-evolution.csl (JabRef#4814) 86f452f Create heiliger-dienst.csl (JabRef#4815) 5ccd3e9 Update revista-brasileira-de-ciencia-do-solo.csl (JabRef#4817) 0eea734 Fix a delimiter in journal-of-the-royal-society-of-western-australia.csl (JabRef#4811) 1cbe790 Delete heiliger-dienst.csl 19fa29f Create heiliger-dienst.csl (JabRef#4787) 888bad1 Update RMIT Harvard to match Easy Cite (JabRef#4788) 46011dd Create universite-nangui-abrogoua-ufr-sn (JabRef#4676) 174adab Create apa-6th-edition-no-ampersand.csl (JabRef#4767) 03cf65f Create journal-of-plant-protection-research.csl (JabRef#4797) c749084 Update eksploatacja-i-niezawodnosc.csl (JabRef#4782) 17e1501 Update masarykova-univerzita-pravnicka-fakulta.csl (JabRef#4783) 5596d18 Update revista-brasileira-de-ciencia-do-solo.csl (JabRef#4790) 9c1a381 create csl for the journal Textual Cultures (JabRef#4785) 8345762 Update taylor-and-francis-national-library-of-medicine.csl (JabRef#4786) 5ec1acf Create british-journal-of-criminology.csl (JabRef#4789) 68550ac Update angewandte-chemie.csl (JabRef#4791) 09e2755 Create shock.csl (JabRef#4792) d46e49e Update antioxidants-and-redox-signaling.csl (JabRef#4793) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: c5f14e2

c5f14e2 Update journal-of-plant-ecology.csl (#4837) b5d00ab Hotfix: pravnik.csl & iso690-full-note-cs.csl (#4833) fb8d48a add PMID and DOI (#4832) 7ebdfff Update lancaster-university-harvard.csl (#4836) 8771e21 Create journal-of-clinical-neurology.csl (#4835) 70beb7b Harvard Lancaster: Fix in-text locator 0709b73 Update informal-logic.csl (#4831) d18d133 Update gost-r-7-0-5-2008.csl (#4829) cfb5389 Update gost-r-7-0-5-2008-numeric.csl (#4828) 0fc46ea Update gost-r-7-0-5-2008-numeric-alphabetical.csl (#4827) fac26cb Create feminist-theory.csl (#4830) a2721e6 Update pravnik.csl, masarykova-univerzita-pravnicka-fakulta.csl, and iso690-full-note-cs.csl (#4826) 2f0d735 Improve localization of DGfP 683d7d1 Create zeitschrift-fur-theologie-und-philosophie.csl (#4813) 7c82406 always show DOI in aps.csl (#4820) 1eb531d Update journal-of-international-business-studies.csl (#4819) 9caf926 Create interdisziplinare-anthropologie.csl (#4818) 00210e1 UKSW2 (#4807) 015db6e UKSW1 (#4800) f706ef5 Update masarykova-univerzita-pravnicka-fakulta.csl (#4822) 096108d Update epilepsia.csl (#4823) 07ebdc3 Update eksploatacja-i-niezawodnosc.csl (#4824) 3d50f3c Create ABNT-Universidade-Federal-de-Pernambuco-CFCH.csl (#4798) df94fa1 Update eksploatacja-i-niezawodnosc.csl (#4808) 4089be5 Update bulletin-de-la-societe-prehistorique-francaise.csl (#4810) f130aa7 Update molecular-biology-and-evolution.csl (#4814) 86f452f Create heiliger-dienst.csl (#4815) 5ccd3e9 Update revista-brasileira-de-ciencia-do-solo.csl (#4817) 0eea734 Fix a delimiter in journal-of-the-royal-society-of-western-australia.csl (#4811) 1cbe790 Delete heiliger-dienst.csl 19fa29f Create heiliger-dienst.csl (#4787) 888bad1 Update RMIT Harvard to match Easy Cite (#4788) 46011dd Create universite-nangui-abrogoua-ufr-sn (#4676) 174adab Create apa-6th-edition-no-ampersand.csl (#4767) 03cf65f Create journal-of-plant-protection-research.csl (#4797) c749084 Update eksploatacja-i-niezawodnosc.csl (#4782) 17e1501 Update masarykova-univerzita-pravnicka-fakulta.csl (#4783) 5596d18 Update revista-brasileira-de-ciencia-do-solo.csl (#4790) 9c1a381 create csl for the journal Textual Cultures (#4785) 8345762 Update taylor-and-francis-national-library-of-medicine.csl (#4786) 5ec1acf Create british-journal-of-criminology.csl (#4789) 68550ac Update angewandte-chemie.csl (#4791) 09e2755 Create shock.csl (#4792) d46e49e Update antioxidants-and-redox-signaling.csl (#4793) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: c5f14e2

c5f14e2 Update journal-of-plant-ecology.csl (JabRef#4837) b5d00ab Hotfix: pravnik.csl & iso690-full-note-cs.csl (JabRef#4833) fb8d48a add PMID and DOI (JabRef#4832) 7ebdfff Update lancaster-university-harvard.csl (JabRef#4836) 8771e21 Create journal-of-clinical-neurology.csl (JabRef#4835) 70beb7b Harvard Lancaster: Fix in-text locator 0709b73 Update informal-logic.csl (JabRef#4831) d18d133 Update gost-r-7-0-5-2008.csl (JabRef#4829) cfb5389 Update gost-r-7-0-5-2008-numeric.csl (JabRef#4828) 0fc46ea Update gost-r-7-0-5-2008-numeric-alphabetical.csl (JabRef#4827) fac26cb Create feminist-theory.csl (JabRef#4830) a2721e6 Update pravnik.csl, masarykova-univerzita-pravnicka-fakulta.csl, and iso690-full-note-cs.csl (JabRef#4826) 2f0d735 Improve localization of DGfP 683d7d1 Create zeitschrift-fur-theologie-und-philosophie.csl (JabRef#4813) 7c82406 always show DOI in aps.csl (JabRef#4820) 1eb531d Update journal-of-international-business-studies.csl (JabRef#4819) 9caf926 Create interdisziplinare-anthropologie.csl (JabRef#4818) 00210e1 UKSW2 (JabRef#4807) 015db6e UKSW1 (JabRef#4800) f706ef5 Update masarykova-univerzita-pravnicka-fakulta.csl (JabRef#4822) 096108d Update epilepsia.csl (JabRef#4823) 07ebdc3 Update eksploatacja-i-niezawodnosc.csl (JabRef#4824) 3d50f3c Create ABNT-Universidade-Federal-de-Pernambuco-CFCH.csl (JabRef#4798) df94fa1 Update eksploatacja-i-niezawodnosc.csl (JabRef#4808) 4089be5 Update bulletin-de-la-societe-prehistorique-francaise.csl (JabRef#4810) f130aa7 Update molecular-biology-and-evolution.csl (JabRef#4814) 86f452f Create heiliger-dienst.csl (JabRef#4815) 5ccd3e9 Update revista-brasileira-de-ciencia-do-solo.csl (JabRef#4817) 0eea734 Fix a delimiter in journal-of-the-royal-society-of-western-australia.csl (JabRef#4811) 1cbe790 Delete heiliger-dienst.csl 19fa29f Create heiliger-dienst.csl (JabRef#4787) 888bad1 Update RMIT Harvard to match Easy Cite (JabRef#4788) 46011dd Create universite-nangui-abrogoua-ufr-sn (JabRef#4676) 174adab Create apa-6th-edition-no-ampersand.csl (JabRef#4767) 03cf65f Create journal-of-plant-protection-research.csl (JabRef#4797) c749084 Update eksploatacja-i-niezawodnosc.csl (JabRef#4782) 17e1501 Update masarykova-univerzita-pravnicka-fakulta.csl (JabRef#4783) 5596d18 Update revista-brasileira-de-ciencia-do-solo.csl (JabRef#4790) 9c1a381 create csl for the journal Textual Cultures (JabRef#4785) 8345762 Update taylor-and-francis-national-library-of-medicine.csl (JabRef#4786) 5ec1acf Create british-journal-of-criminology.csl (JabRef#4789) 68550ac Update angewandte-chemie.csl (JabRef#4791) 09e2755 Create shock.csl (JabRef#4792) d46e49e Update antioxidants-and-redox-signaling.csl (JabRef#4793) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: c5f14e2

* Squashed 'src/main/resources/csl-styles/' changes from 586e0b8..c5f14e2 c5f14e2 Update journal-of-plant-ecology.csl (#4837) b5d00ab Hotfix: pravnik.csl & iso690-full-note-cs.csl (#4833) fb8d48a add PMID and DOI (#4832) 7ebdfff Update lancaster-university-harvard.csl (#4836) 8771e21 Create journal-of-clinical-neurology.csl (#4835) 70beb7b Harvard Lancaster: Fix in-text locator 0709b73 Update informal-logic.csl (#4831) d18d133 Update gost-r-7-0-5-2008.csl (#4829) cfb5389 Update gost-r-7-0-5-2008-numeric.csl (#4828) 0fc46ea Update gost-r-7-0-5-2008-numeric-alphabetical.csl (#4827) fac26cb Create feminist-theory.csl (#4830) a2721e6 Update pravnik.csl, masarykova-univerzita-pravnicka-fakulta.csl, and iso690-full-note-cs.csl (#4826) 2f0d735 Improve localization of DGfP 683d7d1 Create zeitschrift-fur-theologie-und-philosophie.csl (#4813) 7c82406 always show DOI in aps.csl (#4820) 1eb531d Update journal-of-international-business-studies.csl (#4819) 9caf926 Create interdisziplinare-anthropologie.csl (#4818) 00210e1 UKSW2 (#4807) 015db6e UKSW1 (#4800) f706ef5 Update masarykova-univerzita-pravnicka-fakulta.csl (#4822) 096108d Update epilepsia.csl (#4823) 07ebdc3 Update eksploatacja-i-niezawodnosc.csl (#4824) 3d50f3c Create ABNT-Universidade-Federal-de-Pernambuco-CFCH.csl (#4798) df94fa1 Update eksploatacja-i-niezawodnosc.csl (#4808) 4089be5 Update bulletin-de-la-societe-prehistorique-francaise.csl (#4810) f130aa7 Update molecular-biology-and-evolution.csl (#4814) 86f452f Create heiliger-dienst.csl (#4815) 5ccd3e9 Update revista-brasileira-de-ciencia-do-solo.csl (#4817) 0eea734 Fix a delimiter in journal-of-the-royal-society-of-western-australia.csl (#4811) 1cbe790 Delete heiliger-dienst.csl 19fa29f Create heiliger-dienst.csl (#4787) 888bad1 Update RMIT Harvard to match Easy Cite (#4788) 46011dd Create universite-nangui-abrogoua-ufr-sn (#4676) 174adab Create apa-6th-edition-no-ampersand.csl (#4767) 03cf65f Create journal-of-plant-protection-research.csl (#4797) c749084 Update eksploatacja-i-niezawodnosc.csl (#4782) 17e1501 Update masarykova-univerzita-pravnicka-fakulta.csl (#4783) 5596d18 Update revista-brasileira-de-ciencia-do-solo.csl (#4790) 9c1a381 create csl for the journal Textual Cultures (#4785) 8345762 Update taylor-and-francis-national-library-of-medicine.csl (#4786) 5ec1acf Create british-journal-of-criminology.csl (#4789) 68550ac Update angewandte-chemie.csl (#4791) 09e2755 Create shock.csl (#4792) d46e49e Update antioxidants-and-redox-signaling.csl (#4793) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: c5f14e2 * Squashed 'src/main/resources/csl-styles/' changes from c5f14e2..716f635 716f635 Update changes in Harvard-Stellenbosch (#4862) a6a9a1a Create alkoholizmus-a-drogove-zavislosti.csl (#4859) 0560ca0 Update journal-of-the-american-college-of-surgeons.csl (#4858) 9e16631 create independent style for cellular-and-molecular-gastroenterology-and-hepatology.csl (#4852) 87b0853 Update antiquity.csl (#4841) cb4e7f7 Update heart-rhythm.csl (#4850) b3b55ee Create iisue-moderno (#4846) 63973a7 Create etasr.csl (#4848) 9942138 Create style for Journal of Vertebrate Biology (#4849) 7c7f3d3 Add Future Medicine dependents (#4838) abe2066 Update methods-of-information-in-medicine.csl (#4847) c64d98b create independent style for new-zealand-journal-of-forestry-science (#4844) 28265f9 Create continuity-and-change.csl (#4839) d065fdd Create journal-of-clinical-ethics.csl (#4842) b9fbfa3 Update future-medicine.csl (#4843) ceb56fa Create future-medicine.csl (#4834) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 716f635 * Squashed 'src/main/resources/csl-styles/' changes from 716f635..a995c63 a995c63 Create errata.csl (#4894) 883b9cd Update archeologie-medievale.csl (#4892) a942b5c Update rmit-university-harvard.csl (#4890) 5d535fc Update universidade-do-porto-faculdade-de-engenharia-chicago.csl (#4891) f2a8fe3 Fix AVMA style c5a2d7e Create universidade-do-porto-faculdade-de-engenharia-chicago.csl (#4872) 9f106eb Update rmit-university-harvard.csl (#4884) 5213c2f Update universitetet-i-oslo-rettsvitenskap.csl (#4886) 7e0828d Update uclouvain-centre-charles-de-visscher-pour-le-droit-internation… (#4871) ae5eba3 Create revue-archeologique-de-lest.csl (#4881) 58a1672 Create pacific-conservation-biology.csl (#4880) 381106e Update national-institute-of-organisation-dynamics-australia-harvard.csl (#4879) c66a5c0 Create society-of-biblical-literature-author-date.csl (#4812) 008073c Create ruhr-universitat-bochum-medizinische-fakultat-variante-a.csl (#4874) 193385a Update manchester (#4878) fa9ef11 Create Faculty of Psychology and Education Sciences, Porto (#4856) 2f70b14 Add "personal communication" to remaining APA locales (#4866) 2b4f831 Fixed page-range-format (#4863) d5661ba universitat-bern-institut-fur-musikwissenschaft add missing cs:sort to cs:bibliography (#4860) e433c99 fix delimiter issue for bioscience.csl (#4876) 4d97aab update et-al settings for stroke.csl (#4875) 342b9e3 Update masarykova-univerzita-pravnicka-fakulta.csl (#4868) 91fe25e Add article number to IEEE (#4867) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: a995c63 * Squashed 'src/main/resources/csl-styles/' changes from a995c63..bf698ac bf698ac Create common-market-law-review.csl (#4910) c962eca Create harvard-prifysgol-caerdydd.csl (#4922) 0c24e7f Update gewerblicher-rechtsschutz-und-urheberrecht.csl (#4923) d2ec1a7 Create Tijdschrift-voor-Geneeskunde.csl (#4907) 5df7250 Update harvard-institut-fur-praxisforschung-de.csl (#4918) 093fd91 Update universite-de-montreal-apa.csl (#4916) a3e41d4 Update thieme-german.csl (#4919) 648765a add DOI to aerosol-science-and-technology.csl (#4909) bc1ebee Reindent/reorder a8dc18a Fix documentation link for epidemiology & infection aab403a Fix AGLC Newspaper date 4c018d5 Add period between editor and translator (SBL styles) (#4906) 42f7491 Create geographische-zeitschrift.csl (#4898) a4002a6 Create german-kunstwissenschaft.csl (#4896) b01910b Disambiguation of names (#4895) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: bf698ac * Squashed 'src/main/resources/csl-styles/' changes from bf698ac..7cab2f7 7cab2f7 Create depro-ufs.csl (#4947) 2fcda1f Create journal-of-sport-science-and-medicine.csl (#4949) cd457d4 Update american-marketing-association.csl (#4945) cacc4ee Create nejm-catalyst.csl (#4943) bd769b9 Update and rename dependent/chinese-medical-journal.csl to chinese-me… (#4941) 1f706cd Update health-services-research.csl (#4939) 76bcd1d Update journal-of-the-royal-society-of-western-australia.csl (#4932) e79640e Create afro-asia.csl (#4934) c601aa4 Update lancaster-university-harvard.csl (#4938) 184fd90 Update collection-du-centre-jean-berard.csl (#4936) 82f9aec fix et-al & add DOI thyroid.csl (#4937) 4af169f Create universidade-estadual-de-alagoas-uneal-abnt (#4885) 47165b3 Update and rename medical-physics.csl to dependent/medical-physics.csl (AMA) (#4905) 3cab27d Update thieme-german.csl (#4931) eb2c977 Create zeitschrift-fur-zahnarztliche-implantologie.csl (#4925) 4adb1ea Create karstenia.csl (#4929) 530a136 Fix author substitute in Universita Cattolica git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 7cab2f7 * Squashed 'src/main/resources/csl-styles/' changes from 7cab2f7..827b986 827b986 add DOI preprint to american-society-for-microbiology.csl (#4946) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 827b986 * Squashed 'src/main/resources/csl-styles/' changes from 827b986..eb0d37e eb0d37e Create natbib-plainnat-author-dat.csl (#4967) fb1592a Update journal-of-fish-biology.csl (#4969) f6876cb Update .travis.yml (#4970) d6d400b Create london-review-of-international-law.csl (#4966) d2a5ae1 Update harvard-stellenbosch-university.csl (#4965) 9c62141 Create phytopathologia-mediterranea.csl (#4964) 8ca2ea1 Update historical-materialism.csl (#4960) 80456dc Update historical-materialism.csl be2d910 Update historical-materialism.csl 1d1cf09 Create atlande.csl (#4930) 89f41d4 Create juristische-zitierweise-oeffentliches-recht.csl (#4944) 8c677a0 Create korean-journal-of-gastroenterology.csl (#4954) eadb950 Create historical-materialism.csl (#4955) 5553dcd Create revista-materia.csl (#4957) d23a3ab Bug fix in APA 6 original publication macro (#4959) 66f9974 Always print publisher in APA 6th edition (#4899) 868809c Create agora.csl (#4940) 99c19c3 Update anthropologie-et-societes.csl (#4952) ee17423 Create critical-reviews-in-solid-state-and-materials-science.csl (#4951) 7a13a7d Create korean-journal-of-internal-medicine.csl (#4953) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: eb0d37e * Merged new library actions * l10n * Removed unused constructor * Fixed checkstyle failed check * Fixed one more checkstyle issue Co-authored-by: github actions <jabrefmail+webfeedback@gmail.com>

r0light added 3 commits March 27, 2019 14:58

refactored JabRefFrame.output and FXDialogService.notify to only use …

3ab1bd7

…FXDialogService.notify

added logging to notifications and fixed problem with logger in JabRe…

577de6a

…fGUI

moved copying of logevents to GuiAppender

7e20650

Siedlerchr requested changes Mar 28, 2019

View reviewed changes

r0light added 2 commits March 28, 2019 09:16

directly use dialogService in BasePanel

23362fa

Merge branch 'master' into enhancedMessageLog

7995593

r0light changed the title ~~[WIP] Enhanced message log~~ Enhanced message log Mar 28, 2019

tobiasdiez requested changes Mar 28, 2019

View reviewed changes

r0light added 2 commits March 28, 2019 22:59

changed constructor to avoid NPE

deff466

Merge branch 'enhancedMessageLog' of github.com:r0light/jabref into e…

e5cb625

…nhancedMessageLog

tobiasdiez approved these changes Mar 28, 2019

View reviewed changes

r0light added 2 commits March 29, 2019 14:02

Merge branch 'master' into enhancedMessageLog

7ccf914

Merge branch 'master' into enhancedMessageLog

67e33e1

r0light changed the title ~~Enhanced message log~~ [WIP] Enhanced message log Apr 2, 2019

refactored code so that DialogService.notify does not need DefaultTas…

0444b6a

…kExecutor.runInJavaFXThread

Siedlerchr reviewed Apr 2, 2019

View reviewed changes

r0light added 2 commits April 2, 2019 21:49

replaced old swing dialog

f2a31d0

replaced another swing dialog

d87c7f6

r0light commented Apr 2, 2019

View reviewed changes

tobiasdiez requested a review from Siedlerchr April 2, 2019 20:41

Merge branch 'master' into enhancedMessageLog

ea3e786

r0light changed the title ~~[WIP] Enhanced message log~~ Enhanced message log Apr 3, 2019

Siedlerchr approved these changes Apr 3, 2019

View reviewed changes

Siedlerchr merged commit a273eb1 into JabRef:master Apr 3, 2019

r0light mentioned this pull request Apr 5, 2019

removed default constructor of FXDialogService #4847

Merged

6 tasks

Uh oh!

Conversation

r0light commented Mar 27, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tobiasdiez left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Siedlerchr Mar 28, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

r0light Apr 2, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

r0light commented Apr 2, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tobiasdiez commented Apr 2, 2019

Uh oh!

r0light commented Apr 3, 2019

Uh oh!

Siedlerchr commented Apr 3, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

r0light commented Mar 27, 2019 •

edited

Loading

Siedlerchr Mar 28, 2019 •

edited

Loading

r0light Apr 2, 2019 •

edited

Loading

r0light commented Apr 2, 2019 •

edited

Loading