Skip to content

Adds a browse button next to the path text field for aux-based groups#4743

Merged
tobiasdiez merged 6 commits into
JabRef:masterfrom
samiyac:fix-for-issue-4586
Mar 11, 2019
Merged

Adds a browse button next to the path text field for aux-based groups#4743
tobiasdiez merged 6 commits into
JabRef:masterfrom
samiyac:fix-for-issue-4586

Conversation

@samiyac

@samiyac samiyac commented Mar 10, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes #4586
Added a browse button for aux-based groups.

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Manually tested changed features in running JabRef
  • Screenshots added in PR description (for bigger UI changes)
  • Ensured that the git commit message is a good one
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

@samiyac

samiyac commented Mar 10, 2019

Copy link
Copy Markdown
Contributor Author

I am relatively new to contributing to FOSS. Could one help me understand why the check failed and how I can resolve it?

Siedlerchr
Siedlerchr reviewed Mar 10, 2019
View reviewed changes
Comment thread src/main/java/org/jabref/gui/groups/GroupDialog.java Outdated
Siedlerchr
Siedlerchr reviewed Mar 10, 2019
View reviewed changes
Comment thread src/main/java/org/jabref/gui/groups/GroupDialog.java Outdated
Siedlerchr
Siedlerchr requested changes Mar 10, 2019
View reviewed changes

@Siedlerchr Siedlerchr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! The code looks so far, just some minor changes

@Siedlerchr

Siedlerchr commented Mar 10, 2019

Copy link
Copy Markdown
Member

@samiyac

I am relatively new to contributing to FOSS. Could one help me understand why the check failed and how I can resolve it?

The failing check codecov refers to the Code Coverage, e..g how much of the code functionality is covered with tests. You can ignore it in most cases. We only tend to write tests for the most important parts (e.g. the classes in logic/model) and not for GUI dialogs.
Only if the Travis CI fails, you should check the details and see where and what error occurred, as this executes the checkstyle and the integration tests.

Siedlerchr
Siedlerchr reviewed Mar 10, 2019
View reviewed changes
Comment thread src/main/java/org/jabref/gui/groups/GroupDialog.java Outdated
tobiasdiez
tobiasdiez reviewed Mar 11, 2019
View reviewed changes
Comment thread src/main/java/org/jabref/gui/groups/GroupDialog.java Outdated
tobiasdiez
tobiasdiez approved these changes Mar 11, 2019
View reviewed changes

@tobiasdiez tobiasdiez left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick follow-up. Code looks good to me now so I'll merge.

@tobiasdiez tobiasdiez merged commit fa984a7 into JabRef:master Mar 11, 2019
@samiyac samiyac deleted the fix-for-issue-4586 branch March 12, 2019 14:32
Siedlerchr added a commit that referenced this pull request Mar 16, 2019
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into isomedlineformatt…
2670bd1 
…erbibtexkey

* upstream/master: (827 commits)
  [#4306] Disable renaming (#4727)
  Feature: implement search filter in show preferences (#4759)
  Enable import button only if entry selected (#4761)
  Improve Remote messaging (#4760)
  Add changelog entry for #4520
  Modifications to improve contrast of UI elements (#4758)
  Rework external changes dialog in JavaFX (#4693)
  Changes the title of Group Dialog to Add subgroup when adding a new subgroup (#4757)
  Optimize data fetching (#4520)
  Adds a browse button next to the path text field for aux-based groups (#4743)
  Saving changes and exiting application (#4729)
  Code optimized and created a reusable method to get writer output (#4750)
  Bump mvvmfx from 1.7.0 to 1.8.0 (#4747)
  Bump guava from 27.0.1-jre to 27.1-jre (#4748)
  Bump mvvmfx-validation from 1.7.0 to 1.8.0 (#4749)
  Remove obsolete swing components in Preferences and OpenOffice (#4740)
  Move library specific key pattern dialog call to library menu (#4744)
  Revert "Revert "Fix: bibkey generated does not handle diacritics" (#4741)" (#4742)
  Revert "Fix: bibkey generated does not handle diacritics" (#4741)
  Rename method to removeUnwantedCharacters
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Siedlerchr Siedlerchr Siedlerchr requested changes

@tobiasdiez tobiasdiez tobiasdiez approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@samiyac @Siedlerchr @tobiasdiez