Solution for submitting dialog with Ctrl + Enter (#4496)#4592
Merged
Conversation
Siedlerchr
approved these changes
Jan 19, 2019
Siedlerchr
left a comment
Member
There was a problem hiding this comment.
looks good to me! Thanks for your contribution
tobiasdiez
approved these changes
Jan 22, 2019
tobiasdiez
left a comment
Member
There was a problem hiding this comment.
Thanks for your contribution. The code looks good to me as well.
Looking forward to the next PR from you ;-)
Siedlerchr
added a commit
that referenced
this pull request
Jan 27, 2019
* upstream/master: (229 commits) Try to fix not on FX thread for search and autocomplete (#4618) Convert DuplicateResolverDialog to javafx (#4601) Fix for BibTex source tab parsing issue if field contains {} (#4581) Convert OO/LO SidePanel to javafx (#4341) Convert "Customize importer" dialog to JavaFX (#4608) Convert "From Aux file" dialog to JavaFX (#4607) Convert "Show preferences" dialog to JavaFX (#4605) Fix not on FX thread exception Force javafx to run thread (#4604) Convert new version dialog to JavaFX (#4602) Add a variable to track the change in preview style (#4587) Solution for submitting dialog with Ctrl + Enter (#4496) (#4592) Bump mysql-connector-java from 8.0.13 to 8.0.14 (#4599) Fix overlapping font in id entry type (#4595) update jfoenix and gradle plugins Replace outdated transformer log4j2 with official new one Update journalList.txt Fix for Issue #4437 - Some bugs in preference->Entry table columns (#4546) Don't set column sort type at startup (#4577) Add uncaught exception message (#4565) Converts integrity check dialog to JavaFX (#4559) ... # Conflicts: # build.gradle # src/main/java/org/jabref/gui/FindUnlinkedFilesDialog.java # src/main/java/org/jabref/gui/JabRefFrame.java # src/main/java/org/jabref/gui/fieldeditors/EditorTextArea.java # src/main/java/org/jabref/gui/fieldeditors/EditorTextField.java # src/main/java/org/jabref/gui/openoffice/CitationManager.java # src/main/java/org/jabref/gui/openoffice/OOBibBase.java # src/main/java/org/jabref/gui/openoffice/OpenOfficePanel.java # src/main/java/org/jabref/gui/openoffice/OpenOfficeSidePanel.java
Siedlerchr
added a commit
that referenced
this pull request
Feb 1, 2019
* upstream/master: Fix NPE and not on FX Thread in PreviewPrefs Tabs (#4624) Fix preview style configuration (#4613) Bump wiremock from 2.20.0 to 2.21.0 (#4623) snap: disable tests build, add removable media and specify architectures (#4619) Bump checkstyle from 8.16 to 8.17 (#4620) Fix preferences path: use _JAVA_OPTIONS Try to fix not on FX thread for search and autocomplete (#4618) Update snapcraft.yaml Move to snap folder Convert DuplicateResolverDialog to javafx (#4601) Fix for BibTex source tab parsing issue if field contains {} (#4581) Convert OO/LO SidePanel to javafx (#4341) Convert "Customize importer" dialog to JavaFX (#4608) Convert "From Aux file" dialog to JavaFX (#4607) Convert "Show preferences" dialog to JavaFX (#4605) Fix not on FX thread exception Force javafx to run thread (#4604) Convert new version dialog to JavaFX (#4602) Add a variable to track the change in preview style (#4587) Solution for submitting dialog with Ctrl + Enter (#4496) (#4592) Bump mysql-connector-java from 8.0.13 to 8.0.14 (#4599) # Conflicts: # src/main/resources/l10n/JabRef_en.properties
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created solution for suggested improvement described in #4496
Adjusted BaseDialog class to watch for new KeyBinding combination (default: ctrl + ENTER). When such combination is pressed in any dialog which extends BaseDialog, then system tries to find button with default action. If such button is found, then its event is fired.
Additional tests were not created as there currently is no BaseDialogTest test suite and existing dialog tests should cover the changes. In my opinion, quite major refactoring should be made to easily create unit tests for BaseDialog class.