Skip to content

Add oaDOI fulltext fetcher#3581

Merged
tobiasdiez merged 2 commits into
masterfrom
addoadoiFetcher
Jan 2, 2018
Merged

Add oaDOI fulltext fetcher#3581
tobiasdiez merged 2 commits into
masterfrom
addoadoiFetcher

Conversation

@tobiasdiez

@tobiasdiez tobiasdiez commented Dec 27, 2017

Copy link
Copy Markdown
Member

As wished in #2581.

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • If you changed the localization: Did you run gradle localizationUpdate?

@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Dec 27, 2017
lenhard
lenhard suggested changes Jan 2, 2018
View reviewed changes

@lenhard lenhard left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from one naming issues, the code looks fine.

However, I executed this branch and the fetcher did not appear in the web search side pane. It should, right? Am I doing something wrong?

Comment thread src/main/java/org/jabref/logic/importer/fetcher/oaDOI.java Outdated
*
* @implSpec API is documented at https://oadoi.org/api/v2
*/
public class oaDOI implements FulltextFetcher {

@lenhard lenhard Jan 2, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not an "ok" name according to the naming conventions for Java classes: they need to start with upper case. Please rename this to OaDOI or maybe OaDoi. Maybe OpenAccessDoi would be even better.

@tobiasdiez tobiasdiez Jan 2, 2018

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I wasn't sure about the naming conventions and this service seems to be really called oaDOI. But OpenAccessDoi is good.

@tobiasdiez

tobiasdiez commented Jan 2, 2018

Copy link
Copy Markdown
Member Author

@lenhard It is only a fulltext fetcher. Thus it never appears in the GUI but is used when you click the "fetch fulltext" button in the entry editor. It looks for an URL for the paper based on the information in the entry (such as DOI).

@tobiasdiez tobiasdiez merged commit b246b9c into master Jan 2, 2018
@tobiasdiez tobiasdiez deleted the addoadoiFetcher branch January 2, 2018 21:23
@stefan-kolb stefan-kolb mentioned this pull request Jan 2, 2018
Closed
5 tasks
Siedlerchr added a commit that referenced this pull request Jan 2, 2018
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into selectFilesDlg
d3daaa6 
* upstream/master:
  Add oaDOI fulltext fetcher (#3581)
  Refactor export code to fix #3576 (#3578)
  Fix #3359: Automatically remove colon and apostrophe from key pattern (#3506)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

+1 more reviewer

@lenhard lenhard lenhard requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tobiasdiez @Siedlerchr @lenhard