Skip to content

Fixes #3505: Another try to fix the NPE in the search bar#3512

Merged
tobiasdiez merged 1 commit into
masterfrom
fix3505
Dec 13, 2017
Merged

Fixes #3505: Another try to fix the NPE in the search bar#3512
tobiasdiez merged 1 commit into
masterfrom
fix3505

Conversation

@tobiasdiez

@tobiasdiez tobiasdiez commented Dec 10, 2017 •
edited by koppor
Loading

Copy link
Copy Markdown
Member

Fiexes #3505

I think, I managed to locate the problem of the NPE and the missing search bar. Apparently, in some conditions the syntax ../ to access the parent in a path does not work for resources. Thus the css file is not found, resulting in a NPE.

  • Change in CHANGELOG.md described (bug introduced in 4.1dev)
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • If you changed the localization: Did you run gradle localizationUpdate?

@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Dec 10, 2017
@tobiasdiez tobiasdiez mentioned this pull request Dec 10, 2017
Closed
1 task
Siedlerchr
Siedlerchr approved these changes Dec 10, 2017
View reviewed changes

@Siedlerchr Siedlerchr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Seems really odd this error only occurs on certain systems

@koppor

koppor commented Dec 11, 2017

Copy link
Copy Markdown
Member

Search bar appears here. I think, @j0hannes should run the build at his system. Currently, one has to checkout the code and execute ./gradlew run as we currently have issues with our code signing certificate.

@j0hannes

j0hannes commented Dec 12, 2017

Copy link
Copy Markdown

@koppor I just rebuilt the package from git and the search bar is still not there.

@tobiasdiez

tobiasdiez commented Dec 13, 2017

Copy link
Copy Markdown
Member Author

@j0hannes did you checked-out the branch fix3505 or still used the master? Since this PR is not yet merged, the fix is not included in the master branch. If you used the correct branch to build, is the same error message still there?

@tobiasdiez

tobiasdiez commented Dec 13, 2017

Copy link
Copy Markdown
Member Author

Anyway, I merge this now since the code still works under normal conditions and might help in others. So a new checkout of the master branch should work now.

@tobiasdiez tobiasdiez merged commit 47226fd into master Dec 13, 2017
@tobiasdiez tobiasdiez deleted the fix3505 branch December 13, 2017 00:02
@j0hannes

j0hannes commented Dec 13, 2017

Copy link
Copy Markdown

@tobiasdiez Now it's back. The package will certainly only use the master branch; I though it was already merged there.

@tobiasdiez

tobiasdiez commented Dec 13, 2017

Copy link
Copy Markdown
Member Author

@j0hannes thanks for the feedback and your help debugging this issue! Much appreciated.

Siedlerchr added a commit that referenced this pull request Dec 13, 2017
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into sharelatex
74151de 
* upstream/master: (108 commits)
  Fetcher for IACR eprints (#3473)
  Update internal state of DatabaseChangeMonitor when external changes … (#3503)
  Fixes #3505: Another try to fix the NPE in the search bar (#3512)
  Replace ' with ' so that our HTML preview can handle it correctly
  Added a "Clear text" button in right click menu within the text boxes. (#3475)
  Add reset to English language after a test
  New translations JabRef_en.properties (German)
  Remove ampersand in non-menu localizations
  New translations JabRef_en.properties (German)
  New translations Menu_en.properties (German)
  New translations Menu_en.properties (German)
  New translations JabRef_en.properties (Vietnamese)
  New translations JabRef_en.properties (Italian)
  New translations Menu_en.properties (Italian)
  New translations JabRef_en.properties (Indonesian)
  New translations Menu_en.properties (Indonesian)
  New translations JabRef_en.properties (Greek)
  New translations Menu_en.properties (Greek)
  New translations Menu_en.properties (Japanese)
  New translations JabRef_en.properties (German)
  ...

# Conflicts:
#	build.gradle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees

No one assigned

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tobiasdiez @koppor @j0hannes @Siedlerchr