Added a "Clear text" button in right click menu within the text boxes. by weidafan · Pull Request #3475 · JabRef/jabref

weidafan · 2017-12-01T00:19:09Z

Adresses koppor#198

Revised pull request from Monday 11/27. #3465

It was requested to have a new button within the right click menu of text boxes when creating or editing library entries. See this link for description
We created a new class that extended MenuItem to create the instance of the ClearField.
We added the instance into the menuItem array so that it would be included in the right click menu.

There is a possibility to make each text box a clearable text box, with a red "x" in the corner to clear the text box even quicker. We could not target where to change the type of text box, so that feature still remains.

Change in CHANGELOG.md described
Tests created for changes
Screenshots added (for bigger UI changes)
Manually tested changed features in running JabRef
Check documentation status (Issue created for outdated help page at help.jabref.org?)
If you changed the localization: Did you run gradle localizationUpdate?

Siedlerchr · 2017-12-01T09:00:36Z

For future contributions, please always update the existing PR (except you messed up) . That makes it easier to follow and review your code. On merge all commits will be squashed into one

weidafan · 2017-12-01T14:16:11Z

I am sorry. I am a beginner. This is my first pull request and I did mess up my whole JabRef program. I rebuilded the whole program. Thank you for your advise.

lenhard

I have a few very minor comments that should be addressed, but apart from that the PR looks good.

Thanks for your contribution!

lenhard · 2017-12-04T13:11:40Z

 - We added an option to mass append to fields via the Quality -> set/clear/append/rename fields dialog. [#2721](https://github.com/JabRef/jabref/issues/2721)
 - We added a check on startup to ensure JabRef is run with an adequate Java version. [3310](https://github.com/JabRef/jabref/issues/3310)
 - In the preference, all installed java Look and Feels are now listed and selectable
+- We added the clear text button into the right-click menu of the text field. When adding a new entry into a library, the text boxes are now clearable by clicking this button. Issue 198 in "Beginner" section of "koppor"'s repository. ( https://github.com/jabref/issues/198 )


Please format the link to the issue in the same way as for the other changelog entries.

lenhard · 2017-12-04T13:12:01Z

+        super(Localization.lang("Clear text"));
+        setOnAction(event -> opener.setText(""));
+    }
+}


Please end code files with a new line

lenhard · 2017-12-04T13:12:22Z

        };
    }
-}
+}


As above, please do not remove the new line here.

tobiasdiez

I still have a few remarks before this can be merged.

tobiasdiez · 2017-12-10T15:43:25Z

 - We added an option to mass append to fields via the Quality -> set/clear/append/rename fields dialog. [#2721](https://github.com/JabRef/jabref/issues/2721)
 - We added a check on startup to ensure JabRef is run with an adequate Java version. [3310](https://github.com/JabRef/jabref/issues/3310)
 - In the preference, all installed java Look and Feels are now listed and selectable
+- We added the clear text button into the right-click menu of the text field. When adding a new entry into a library, the text boxes are now clearable by clicking this button. Issue 198 in "Beginner" section of "koppor"'s repository. [#198](https://github.com/jabref/issues/198)


I think the description

We added a clear option to the right-click menu of the text field in the entry editor.
is already sufficient.

Moreover, please reference to the issue in the form koppor#198 and link the correct issue.

tobiasdiez · 2017-12-10T15:48:04Z

+        super(Localization.lang("Clear text"));
+        setOnAction(event -> opener.setText(""));
+    }
+


Well, the new line character is now at the wrong place 😸. It should be after the last brace and not before (the red "no newline at end of file" marker here at github should disappear. Your IDE probably has an option for adding the newline automatically.

tobiasdiez · 2017-12-10T15:48:40Z

+class ClearField extends MenuItem {
+
+    public ClearField(TextArea opener) {
+        super(Localization.lang("Clear text"));


You can also just reuse the text "Clear" here so that our poor translators don't have to work too much.

tobiasdiez · 2017-12-11T08:47:27Z

 Clear=Ryd

 Clear_fields=Ryd_felter
+Clear_text=


You still need to delete these now unused translation strings.

tobiasdiez · 2017-12-12T09:24:12Z

Thanks again for your contribution!

brandonwalker08 · 2017-12-12T20:15:56Z

@tobiasdiez @lenhard @Siedlerchr Thank you all for your help. Our first time contributing to an open source project was a good experience thanks to your feedback.

* upstream/master: (108 commits) Fetcher for IACR eprints (#3473) Update internal state of DatabaseChangeMonitor when external changes … (#3503) Fixes #3505: Another try to fix the NPE in the search bar (#3512) Replace ' with ' so that our HTML preview can handle it correctly Added a "Clear text" button in right click menu within the text boxes. (#3475) Add reset to English language after a test New translations JabRef_en.properties (German) Remove ampersand in non-menu localizations New translations JabRef_en.properties (German) New translations Menu_en.properties (German) New translations Menu_en.properties (German) New translations JabRef_en.properties (Vietnamese) New translations JabRef_en.properties (Italian) New translations Menu_en.properties (Italian) New translations JabRef_en.properties (Indonesian) New translations Menu_en.properties (Indonesian) New translations JabRef_en.properties (Greek) New translations Menu_en.properties (Greek) New translations Menu_en.properties (Japanese) New translations JabRef_en.properties (German) ... # Conflicts: # build.gradle

LinusDietz · 2017-12-22T12:20:18Z

@weidafan We are about to release a new Version of JabRef and would like to attribute you with your full name. Can you tell us your name, so we can include it?

weidafan · 2017-12-22T20:02:02Z

Hello, thank you for you invitation. My full name is Weida Fan.

…

On Dec 22, 2017 7:20 AM, "Linus Dietz" ***@***.***> wrote: @weidafan <https://github.com/weidafan> We are about to release a new Version of JabRef and would like to attribute you with your full name. Can you tell us your name, so we can include it? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3475 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AeRaTxM_X6BZLhlCDlgl27RmFEdYofjKks5tC56FgaJpZM4Qxrvm> .

revised clear field

d432d2f

Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Dec 3, 2017

lenhard suggested changes Dec 4, 2017

View reviewed changes

weidafan added 2 commits December 5, 2017 18:21

optimized

ed3e40c

add new line to end of code

b5b3788

tobiasdiez requested changes Dec 10, 2017

View reviewed changes

added new line and modified changelog.md

123e762

tobiasdiez reviewed Dec 11, 2017

View reviewed changes

delete language set

d940b82

tobiasdiez merged commit bd42bb4 into JabRef:master Dec 12, 2017

lenhard mentioned this pull request Dec 12, 2017

Right click on label should offer "clear field" JabRef/jabref-koppor#198

Closed

                       };
                   }
-              }
+              }

                
                    No newline at end of file

Uh oh!

Conversation

weidafan commented Dec 1, 2017

Uh oh!

Siedlerchr commented Dec 1, 2017

Uh oh!

weidafan commented Dec 1, 2017

Uh oh!

lenhard left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tobiasdiez left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tobiasdiez commented Dec 12, 2017

Uh oh!

brandonwalker08 commented Dec 12, 2017

Uh oh!

LinusDietz commented Dec 22, 2017

Uh oh!

weidafan commented Dec 22, 2017 via email

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants